From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, rob@landley.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] ether_addr_equal: Optimize implementation, remove unused compare_ether_addr
Date: Fri, 06 Dec 2013 16:37:58 -0500 (EST) [thread overview]
Message-ID: <20131206.163758.1360809557088338617.davem@davemloft.net> (raw)
In-Reply-To: <34a0bad292ab2535a3a2e757a83eca13408e55b7.1386283991.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 5 Dec 2013 14:54:38 -0800
> Add a new check for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to reduce
> the number of or's used in the ether_addr_equal comparison to very
> slightly improve function performance.
>
> Simplify the ether_addr_equal_64bits implementation.
> Integrate and remove the zap_last_2bytes helper as it's now
> used only once.
>
> Remove the now unused compare_ether_addr function.
>
> Update the unaligned-memory-access documentation to remove the
> compare_ether_addr description and show how unaligned accesses
> could occur with ether_addr_equal.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
prev parent reply other threads:[~2013-12-06 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 22:54 [PATCH net-next] ether_addr_equal: Optimize implementation, remove unused compare_ether_addr Joe Perches
2013-12-05 23:32 ` Stephen Hemminger
2013-12-05 23:36 ` Joe Perches
2013-12-06 21:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206.163758.1360809557088338617.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).