From: Guenter Roeck <linux@roeck-us.net>
To: David Miller <davem@davemloft.net>
Cc: zwu.kernel@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wuzhy@linux.vnet.ibm.com
Subject: Re: [net-next PATCH 3/6] macvtap: remove the dead branch
Date: Fri, 6 Dec 2013 09:29:31 -0800 [thread overview]
Message-ID: <20131206172931.GA32730@roeck-us.net> (raw)
In-Reply-To: <20131206.114602.2053541753179744731.davem@davemloft.net>
On Fri, Dec 06, 2013 at 11:46:02AM -0500, David Miller wrote:
> From: Guenter Roeck <linux@roeck-us.net>
> Date: Thu, 05 Dec 2013 22:08:20 -0800
>
> > Assigning the function's return value to ret just to ignore it seems
> > odd.
> >
> > Might make sense to change the function type to void.
>
> That's exactly what his very next patch does, undoubtedly the two
> patches should be combined into one.
>
Yes, I think that would be a good idea.
Thanks,
Guenter
next prev parent reply other threads:[~2013-12-06 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 22:28 [net-next PATCH 0/6] some cleanups Zhi Yong Wu
2013-12-05 22:28 ` [net-next PATCH 1/6] vhost: remove the dead branch Zhi Yong Wu
2013-12-05 22:28 ` [net-next PATCH 2/6] vhost: adjust vhost_dev_init() to be void Zhi Yong Wu
2013-12-05 22:28 ` [net-next PATCH 3/6] macvtap: remove the dead branch Zhi Yong Wu
2013-12-06 6:08 ` Guenter Roeck
2013-12-06 6:11 ` Zhi Yong Wu
2013-12-06 16:46 ` David Miller
2013-12-06 17:29 ` Guenter Roeck [this message]
2013-12-05 22:28 ` [net-next PATCH 4/6] macvtap: adjust macvtap_skb_to_vnet_hdr() to be void Zhi Yong Wu
2013-12-05 22:28 ` [net-next PATCH 5/6] macvtap: update file current position Zhi Yong Wu
2013-12-05 22:28 ` [net-next PATCH 6/6] macvtap: remove unused paramter in macvtap_do_read() Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206172931.GA32730@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).