* [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata()
@ 2013-12-09 3:24 Jingoo Han
2013-12-09 3:25 ` [PATCH 2/5] net: sis900: " Jingoo Han
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Jingoo Han @ 2013-12-09 3:24 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', linux-net-drivers,
'Ben Hutchings'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sfc/efx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 958d8c7..12f60e7 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2643,7 +2643,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
netif_dbg(efx, drv, efx->net_dev, "shutdown successful\n");
efx_fini_struct(efx);
- pci_set_drvdata(pci_dev, NULL);
free_netdev(efx->net_dev);
pci_disable_pcie_error_reporting(pci_dev);
@@ -2837,7 +2836,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
fail2:
efx_fini_struct(efx);
fail1:
- pci_set_drvdata(pci_dev, NULL);
WARN_ON(rc > 0);
netif_dbg(efx, drv, efx->net_dev, "initialisation failed. rc=%d\n", rc);
free_netdev(net_dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/5] net: sis900: remove unnecessary pci_set_drvdata()
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-12-09 3:25 ` Jingoo Han
2013-12-09 23:09 ` David Miller
2013-12-09 3:26 ` [PATCH 3/5] net: bna: " Jingoo Han
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Jingoo Han @ 2013-12-09 3:25 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Daniele Venzano'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sis/sis900.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 975dc2d..ff57a46 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -576,7 +576,6 @@ err_unmap_tx:
err_out_unmap:
pci_iounmap(pci_dev, ioaddr);
err_out_cleardev:
- pci_set_drvdata(pci_dev, NULL);
pci_release_regions(pci_dev);
err_out:
free_netdev(net_dev);
@@ -2427,7 +2426,6 @@ static void sis900_remove(struct pci_dev *pci_dev)
pci_iounmap(pci_dev, sis_priv->ioaddr);
free_netdev(net_dev);
pci_release_regions(pci_dev);
- pci_set_drvdata(pci_dev, NULL);
}
#ifdef CONFIG_PM
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] net: bna: remove unnecessary pci_set_drvdata()
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-12-09 3:25 ` [PATCH 2/5] net: sis900: " Jingoo Han
@ 2013-12-09 3:26 ` Jingoo Han
2013-12-09 23:09 ` David Miller
2013-12-09 3:27 ` [PATCH 4/5] net: ns83820: " Jingoo Han
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Jingoo Han @ 2013-12-09 3:26 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Rasesh Mody'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index 248bc37..3d151bd 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -3262,7 +3262,6 @@ bnad_uninit(struct bnad *bnad)
if (bnad->bar0)
iounmap(bnad->bar0);
- pci_set_drvdata(bnad->pcidev, NULL);
}
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] net: ns83820: remove unnecessary pci_set_drvdata()
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-12-09 3:25 ` [PATCH 2/5] net: sis900: " Jingoo Han
2013-12-09 3:26 ` [PATCH 3/5] net: bna: " Jingoo Han
@ 2013-12-09 3:27 ` Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 3:27 ` [PATCH 5/5] net: forcedeth: " Jingoo Han
2013-12-09 23:09 ` [PATCH 1/5] net: sfc: " David Miller
4 siblings, 1 reply; 11+ messages in thread
From: Jingoo Han @ 2013-12-09 3:27 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/natsemi/ns83820.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index 5213e73..dbccf1d 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -2235,7 +2235,6 @@ out_disable:
pci_disable_device(pci_dev);
out_free:
free_netdev(ndev);
- pci_set_drvdata(pci_dev, NULL);
out:
return err;
}
@@ -2259,7 +2258,6 @@ static void ns83820_remove_one(struct pci_dev *pci_dev)
dev->rx_info.descs, dev->rx_info.phy_descs);
pci_disable_device(dev->pci_dev);
free_netdev(ndev);
- pci_set_drvdata(pci_dev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/5] net: forcedeth: remove unnecessary pci_set_drvdata()
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
` (2 preceding siblings ...)
2013-12-09 3:27 ` [PATCH 4/5] net: ns83820: " Jingoo Han
@ 2013-12-09 3:27 ` Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 23:09 ` [PATCH 1/5] net: sfc: " David Miller
4 siblings, 1 reply; 11+ messages in thread
From: Jingoo Han @ 2013-12-09 3:27 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/nvidia/forcedeth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index ab67bab..d8bdaf6 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -6017,7 +6017,6 @@ static int nv_probe(struct pci_dev *pci_dev, const struct pci_device_id *id)
out_error:
if (phystate_orig)
writel(phystate|NVREG_ADAPTCTL_RUNNING, base + NvRegAdapterControl);
- pci_set_drvdata(pci_dev, NULL);
out_freering:
free_rings(dev);
out_unmap:
@@ -6088,7 +6087,6 @@ static void nv_remove(struct pci_dev *pci_dev)
pci_release_regions(pci_dev);
pci_disable_device(pci_dev);
free_netdev(dev);
- pci_set_drvdata(pci_dev, NULL);
}
#ifdef CONFIG_PM_SLEEP
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata()
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
` (3 preceding siblings ...)
2013-12-09 3:27 ` [PATCH 5/5] net: forcedeth: " Jingoo Han
@ 2013-12-09 23:09 ` David Miller
4 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2013-12-09 23:09 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, linux-net-drivers, bhutchings
From: Jingoo Han <jg1.han@samsung.com>
Date: Mon, 09 Dec 2013 12:24:07 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata()
@ 2013-11-25 1:43 Jingoo Han
2013-11-25 1:46 ` [PATCH 4/5] net: ns83820: " Jingoo Han
0 siblings, 1 reply; 11+ messages in thread
From: Jingoo Han @ 2013-11-25 1:43 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', linux-net-drivers,
'Ben Hutchings'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sfc/efx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 2e27837..ad6b811 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2641,7 +2641,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
netif_dbg(efx, drv, efx->net_dev, "shutdown successful\n");
efx_fini_struct(efx);
- pci_set_drvdata(pci_dev, NULL);
free_netdev(efx->net_dev);
pci_disable_pcie_error_reporting(pci_dev);
@@ -2835,7 +2834,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
fail2:
efx_fini_struct(efx);
fail1:
- pci_set_drvdata(pci_dev, NULL);
WARN_ON(rc > 0);
netif_dbg(efx, drv, efx->net_dev, "initialisation failed. rc=%d\n", rc);
free_netdev(net_dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] net: ns83820: remove unnecessary pci_set_drvdata()
2013-11-25 1:43 Jingoo Han
@ 2013-11-25 1:46 ` Jingoo Han
0 siblings, 0 replies; 11+ messages in thread
From: Jingoo Han @ 2013-11-25 1:46 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/natsemi/ns83820.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
index d3b4700..e3e1e2f 100644
--- a/drivers/net/ethernet/natsemi/ns83820.c
+++ b/drivers/net/ethernet/natsemi/ns83820.c
@@ -2236,7 +2236,6 @@ out_disable:
pci_disable_device(pci_dev);
out_free:
free_netdev(ndev);
- pci_set_drvdata(pci_dev, NULL);
out:
return err;
}
@@ -2260,7 +2259,6 @@ static void ns83820_remove_one(struct pci_dev *pci_dev)
dev->rx_info.descs, dev->rx_info.phy_descs);
pci_disable_device(dev->pci_dev);
free_netdev(ndev);
- pci_set_drvdata(pci_dev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-12-09 23:10 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 3:24 [PATCH 1/5] net: sfc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-12-09 3:25 ` [PATCH 2/5] net: sis900: " Jingoo Han
2013-12-09 23:09 ` David Miller
2013-12-09 3:26 ` [PATCH 3/5] net: bna: " Jingoo Han
2013-12-09 23:09 ` David Miller
2013-12-09 3:27 ` [PATCH 4/5] net: ns83820: " Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 3:27 ` [PATCH 5/5] net: forcedeth: " Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 23:09 ` [PATCH 1/5] net: sfc: " David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-11-25 1:43 Jingoo Han
2013-11-25 1:46 ` [PATCH 4/5] net: ns83820: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).