From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: linux-sctp@vger.kernel.org, wangweidong1@huawei.com,
vyasevich@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sctp: properly latch and use autoclose value from sock to association
Date: Mon, 09 Dec 2013 20:32:38 -0500 (EST) [thread overview]
Message-ID: <20131209.203238.1909015829128815864.davem@davemloft.net> (raw)
In-Reply-To: <1386343755-14130-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 6 Dec 2013 10:29:15 -0500
> @@ -2205,6 +2206,12 @@ static int sctp_setsockopt_autoclose(struct sock *sk, char __user *optval,
> if (copy_from_user(&sp->autoclose, optval, optlen))
> return -EFAULT;
>
> + if (sp->autoclose > net->sctp.max_autoclose) {
> + pr_warn("Capping autoclose value %d to defined maximum of %lu\n",
> + sp->autoclose, net->sctp.max_autoclose);
> + sp->autoclose = net->sctp.max_autoclose;
> + }
Please don't add this warning.
If we already do this for certain setsockopt calls in SCTP, that just
means we have bugs to fix.
next prev parent reply other threads:[~2013-12-10 1:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:09 [PATCH] sctp: fix a BUG_ON on triggered by setting max_autoclose to Wang Weidong
2013-12-03 15:43 ` Neil Horman
2013-12-03 16:09 ` Vlad Yasevich
2013-12-03 18:18 ` Neil Horman
2013-12-03 21:24 ` Vlad Yasevich
2013-12-04 6:21 ` Wang Weidong
2013-12-04 13:28 ` Neil Horman
2013-12-04 14:45 ` Vlad Yasevich
2013-12-04 18:56 ` Neil Horman
2013-12-05 16:00 ` Vlad Yasevich
2013-12-05 20:43 ` Neil Horman
2013-12-06 15:29 ` [PATCH] sctp: properly latch and use autoclose value from sock to association Neil Horman
2013-12-06 15:36 ` Vlad Yasevich
2013-12-06 15:48 ` Neil Horman
2013-12-06 17:22 ` [PATCH v2] " Neil Horman
2013-12-06 18:47 ` Vlad Yasevich
2013-12-07 6:29 ` Wang Weidong
2013-12-10 11:48 ` [PATCH v3] " Neil Horman
2013-12-11 3:42 ` David Miller
2013-12-06 15:46 ` [PATCH] " David Laight
2013-12-06 16:04 ` Neil Horman
2013-12-06 16:29 ` Neil Horman
2013-12-10 1:32 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-10 3:03 nhorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209.203238.1909015829128815864.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
--cc=wangweidong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).