From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net,
hannes@stressinduktion.org, bcrl@kvack.org,
gaofeng@cn.fujitsu.com, joe@perches.com,
herbert@gondor.apana.org.au
Subject: Re: [patch net-next v2 0/5] neigh: respect default parms values
Date: Mon, 09 Dec 2013 20:56:57 -0500 (EST) [thread overview]
Message-ID: <20131209.205657.22934541767894302.davem@davemloft.net> (raw)
In-Reply-To: <1386440817-7846-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 7 Dec 2013 19:26:52 +0100
> This is a long standing regression. But since the patchset is bigger and
> the regression happened in 2007, I'm proposing this to net-next instead.
>
> Basically the problem is that if user wants to use /etc/sysctl.conf to specify
> default values of neigh related params, he is not able to do that.
>
> The reason is that the default values are copied to dev instance right after
> netdev is registered. And that is way to early. The original behaviour
> for ipv4 was that this happened after first address was assigned to device.
> For ipv6 this was apparently from the very beginning.
>
> So this patchset basically reverts the behaviour back to what it was in 2007 for
> ipv4 and changes the behaviour for ipv6 so they are both the same.
>
> v1->v2:
> - use neigh_parms->tbl->family as suggested by davem
Series applied, thanks Jiri.
prev parent reply other threads:[~2013-12-10 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 18:26 [patch net-next v2 0/5] neigh: respect default parms values Jiri Pirko
2013-12-07 18:26 ` [patch net-next v2 1/5] neigh: convert parms to an array Jiri Pirko
2013-12-07 18:26 ` [patch net-next v2 2/5] neigh: wrap proc dointvec functions Jiri Pirko
2013-12-07 18:26 ` [patch net-next v2 3/5] neigh: use tbl->family to distinguish ipv4 from ipv6 Jiri Pirko
2013-12-07 18:26 ` [patch net-next v2 4/5] neigh: restore old behaviour of default parms values Jiri Pirko
2013-12-10 14:09 ` Or Gerlitz
2013-12-10 14:51 ` Jiri Pirko
2013-12-07 18:26 ` [patch net-next v2 5/5] neigh: ipv6: respect default values set before an address is assigned to device Jiri Pirko
2013-12-09 11:52 ` [patch net-next v2 0/5] neigh: respect default parms values Herbert Xu
2013-12-10 1:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209.205657.22934541767894302.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=gaofeng@cn.fujitsu.com \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).