From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: zajec5@gmail.com, netdev@vger.kernel.org, hauke@hauke-m.de
Subject: Re: [PATCH] bgmac: connect to PHY and make use of PHY device
Date: Mon, 09 Dec 2013 20:59:47 -0500 (EST) [thread overview]
Message-ID: <20131209.205947.2139145054909970576.davem@davemloft.net> (raw)
In-Reply-To: <CAGVrzcbQPugVMG7N7y4BP4d_Z2i_DLRqBPVpbqaFQhA4nbM4sQ@mail.gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 6 Dec 2013 16:59:26 -0800
> 2013/12/6 Rafał Miłecki <zajec5@gmail.com>:
>> We were already registering MDIO bus, but we were not connecting bgmac
>> to the PHY. Add proper call and implement adjust link function to switch
>> MAC into requested state.
>> At the same time it's possible to drop our internal PHY management.
>> This is a "standard" PHY, so the "Generic PHY" driver works perfectly
>> fine with this. Don't duplicate the code.
>> Finally make use of phy_ethtool_[gs]set functions instead implementing
>> them from scratch.
>>
>> This change was successfully tested on BCM5357. I was able to
>> autonegotiate 1000Mb/s full duplex, as well as force any of the
>> 10/100/1000 half/full modes.
>
> The diffstat is really impressive, nice job!
>
>>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2013-12-10 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 23:53 [PATCH] bgmac: connect to PHY and make use of PHY device Rafał Miłecki
2013-12-07 0:59 ` Florian Fainelli
2013-12-10 1:59 ` David Miller [this message]
2013-12-07 9:09 ` Rafał Miłecki
2013-12-08 17:50 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209.205947.2139145054909970576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).