* [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format
@ 2013-12-10 12:56 Jiri Pirko
2013-12-10 13:51 ` Florent Fourcot
2013-12-10 18:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2013-12-10 12:56 UTC (permalink / raw)
To: netdev
Cc: davem, kuznet, jmorris, yoshfuji, kaber, thaller, alex.aring,
florent.fourcot
Turned out that applications like ifconfig do not handle the change.
So revert ifa_flag format back to 2-letter hex value.
Introduced by:
commit 479840ffdbe4242e8a25349218c8e0859223aa35
"ipv6 addrconf: extend ifa_flags to u32"
Reported-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
net/ipv6/addrconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index be4dbbd..3c3425e 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3367,12 +3367,12 @@ static void if6_seq_stop(struct seq_file *seq, void *v)
static int if6_seq_show(struct seq_file *seq, void *v)
{
struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v;
- seq_printf(seq, "%pi6 %02x %02x %02x %03x %8s\n",
+ seq_printf(seq, "%pi6 %02x %02x %02x %02x %8s\n",
&ifp->addr,
ifp->idev->dev->ifindex,
ifp->prefix_len,
ifp->scope,
- ifp->flags,
+ (u8) ifp->flags,
ifp->idev->dev->name);
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format
2013-12-10 12:56 [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format Jiri Pirko
@ 2013-12-10 13:51 ` Florent Fourcot
2013-12-10 18:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florent Fourcot @ 2013-12-10 13:51 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, Alexander Aring
Le 10/12/2013 13:56, Jiri Pirko a écrit :
> Turned out that applications like ifconfig do not handle the change.
> So revert ifa_flag format back to 2-letter hex value.
>
Tested-by: FLorent Fourcot <florent.fourcot@enst-bretagne.fr>
It solves the problem, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format
2013-12-10 12:56 [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format Jiri Pirko
2013-12-10 13:51 ` Florent Fourcot
@ 2013-12-10 18:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-10 18:52 UTC (permalink / raw)
To: jiri
Cc: netdev, kuznet, jmorris, yoshfuji, kaber, thaller, alex.aring,
florent.fourcot
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 10 Dec 2013 13:56:29 +0100
> Turned out that applications like ifconfig do not handle the change.
> So revert ifa_flag format back to 2-letter hex value.
>
> Introduced by:
> commit 479840ffdbe4242e8a25349218c8e0859223aa35
> "ipv6 addrconf: extend ifa_flags to u32"
>
> Reported-by: Alexander Aring <alex.aring@gmail.com>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-10 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-10 12:56 [patch net-next] ipv6 addrconf: revert /proc/net/if_inet6 ifa_flag format Jiri Pirko
2013-12-10 13:51 ` Florent Fourcot
2013-12-10 18:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).