From: David Miller <davem@davemloft.net>
To: vyasevich@gmail.com
Cc: zwu.kernel@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wuzhy@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun_recvmsg()
Date: Tue, 10 Dec 2013 14:00:36 -0500 (EST) [thread overview]
Message-ID: <20131210.140036.1328560146971385473.davem@davemloft.net> (raw)
In-Reply-To: <52A74CD1.808@gmail.com>
From: Vlad Yasevich <vyasevich@gmail.com>
Date: Tue, 10 Dec 2013 12:18:09 -0500
> On 12/09/2013 08:36 PM, David Miller wrote:
>> From: Zhi Yong Wu <zwu.kernel@gmail.com>
>> Date: Sat, 7 Dec 2013 04:55:00 +0800
>>
>>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>>>
>>> By checking related codes, it is impossible that ret > len or total_len,
>>> so we should remove some useless codes in both above functions.
>>>
>>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>>
>> Applied.
>
> Wait a sec. We want to be able to return a value bigger then len
> to trigger a MSG_TRUNC. Jason has patches for to fix this. If you
> apply this, we'll have to re-introduce this code back in.
>
> Same goes for patch 1/2.
That's fine, right now the code makes no sense as the condition can
never be triggered so there is no harm removing the illogical code
meanwhile.
next prev parent reply other threads:[~2013-12-10 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 20:54 [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg() Zhi Yong Wu
2013-12-06 20:55 ` [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun_recvmsg() Zhi Yong Wu
2013-12-10 1:36 ` David Miller
2013-12-10 17:18 ` Vlad Yasevich
2013-12-10 19:00 ` David Miller [this message]
2013-12-11 3:14 ` Zhi Yong Wu
2013-12-11 3:19 ` David Miller
2013-12-11 3:24 ` Zhi Yong Wu
2013-12-07 2:38 ` [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg() Vlad Yasevich
2013-12-09 3:30 ` Jason Wang
2013-12-10 1:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210.140036.1328560146971385473.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).