From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: ffusco@redhat.com, netdev@vger.kernel.org, dev@openvswitch.org,
dborkman@redhat.com, tgraf@redhat.com
Subject: Re: [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if available
Date: Tue, 10 Dec 2013 14:36:52 -0500 (EST) [thread overview]
Message-ID: <20131210.143652.1279430126319061689.davem@davemloft.net> (raw)
In-Reply-To: <CAEP_g=_t750s50-F7A_hWD_yNs3MnKWN8WDBjzgoF8Mu+28Wyw@mail.gmail.com>
From: Jesse Gross <jesse@nicira.com>
Date: Tue, 10 Dec 2013 11:28:08 -0800
> I think this is definitely a good optimization to do given that so
> much of the work that OVS does is hashing. However, isn't there a
> library where there would be a more appropriate place to put this?
I also honestly don't see why we want to special case OVS at all
here. This faster hashing would be useful for socket demux and
other locations in the kernel.
When I see changes like this my only reaction is "sad face".
next prev parent reply other threads:[~2013-12-10 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 9:52 [PATCH net-next] net: ovs: use CRC32 accelerated flow hash if available Francesco Fusco
2013-12-10 10:20 ` David Laight
2013-12-10 19:28 ` Jesse Gross
2013-12-10 19:36 ` David Miller [this message]
2013-12-10 20:47 ` Thomas Graf
2013-12-10 21:36 ` Jesse Gross
2013-12-10 22:38 ` David Miller
2013-12-10 21:27 ` Tom Herbert
2013-12-10 21:40 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210.143652.1279430126319061689.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=ffusco@redhat.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).