From: David Miller <davem@davemloft.net>
To: himanshu.madhani@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH net 1/5] qlcnic: Use correct netif api to enable tx queues.
Date: Tue, 10 Dec 2013 17:49:07 -0500 (EST) [thread overview]
Message-ID: <20131210.174907.841340337177313599.davem@davemloft.net> (raw)
In-Reply-To: <a124e077076f2a1d1107200e629945108bd467bd.1386648865.git.himanshu.madhani@qlogic.com>
From: Himanshu Madhani <himanshu.madhani@qlogic.com>
Date: Tue, 10 Dec 2013 12:33:01 -0500
> From: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
> o commit id 012ec81223aa45d2b80aeafb77392fd1a19c7b10
> ("qlcnic: Multi Tx queue support for 82xx Series adapter.")
> enabled multiple tx queue API's for qlcnic driver.
> During link change event, driver will stop/start Tx queues
> which manages Link up event is received after Tx context is created
> driver needs to call netif_tx_wake_all_queues()
>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
This is a symptom of the fact that this driver does not manage it's
queues correctly.
When the carrier is marked off, the core networking will not queue
packets to the device.
You should never manage queue state manually in response to link
state changes, netif_carrir_{on,off}() takes care of everything.
next prev parent reply other threads:[~2013-12-10 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 17:33 [PATCH net 0/5] qlcnic: Bug fixes Himanshu Madhani
2013-12-10 17:33 ` [PATCH net 1/5] qlcnic: Use correct netif api to enable tx queues Himanshu Madhani
2013-12-10 22:49 ` David Miller [this message]
2013-12-10 17:33 ` [PATCH net 2/5] qlcnic: Fix diagnostic test for all supported adapters Himanshu Madhani
2013-12-10 17:33 ` [PATCH net 3/5] qlcnic: Fix Tx/SDS ring validation logic Himanshu Madhani
2013-12-10 17:33 ` [PATCH net 4/5] qlcnic: Fix TSS/RSS validation for 83xx/84xx series adapter Himanshu Madhani
2013-12-10 17:33 ` [PATCH net 5/5] qlcnic: Use spinlock per transmit queue Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210.174907.841340337177313599.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=himanshu.madhani@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).