From: David Miller <davem@davemloft.net>
To: stefan.tomanek@wertarbyte.de
Cc: netdev@vger.kernel.org, daniel.golle@gmail.com,
sergei.shtylyov@cogentembedded.com, eric.dumazet@gmail.com
Subject: Re: [PATCH] inet: fix NULL pointer Oops in fib(6)_rule_suppress
Date: Tue, 10 Dec 2013 17:56:11 -0500 (EST) [thread overview]
Message-ID: <20131210.175611.817301757454300416.davem@davemloft.net> (raw)
In-Reply-To: <20131210222124.GG3260@zirkel.wertarbyte.de>
From: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
Date: Tue, 10 Dec 2013 23:21:25 +0100
> This changes ensures that the routing entry investigated by the suppress
> function actually does point to a device struct before following that pointer,
> fixing a possible kernel oops situation when verifying the interface group
> associated with a routing table entry.
>
> According to Daniel Golle, this Oops can be triggered by a user process trying
> to establish an outgoing IPv6 connection while having no real IPv6 connectivity
> set up (only autoassigned link-local addresses).
>
> Fixes: 6ef94cfafba15 ("fib_rules: add route suppression based on ifgroup")
>
> Reported-by: Daniel Golle <daniel.golle@gmail.com>
> Tested-by: Daniel Golle <daniel.golle@gmail.com>
> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
Looks good, applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2013-12-10 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 22:21 [PATCH] inet: fix NULL pointer Oops in fib(6)_rule_suppress Stefan Tomanek
2013-12-10 22:56 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-08 19:18 Stefan Tomanek
2013-12-08 19:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210.175611.817301757454300416.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.golle@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stefan.tomanek@wertarbyte.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).