From: David Miller <davem@davemloft.net>
To: xemul@parallels.com
Cc: sasha.levin@oracle.com, edumazet@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: unix: allow set_peek_off to fail
Date: Tue, 10 Dec 2013 21:45:46 -0500 (EST) [thread overview]
Message-ID: <20131210.214546.2076606671956419677.davem@davemloft.net> (raw)
In-Reply-To: <52A5721E.6020709@parallels.com>
From: Pavel Emelyanov <xemul@parallels.com>
Date: Mon, 9 Dec 2013 11:32:46 +0400
> On 12/08/2013 02:26 AM, Sasha Levin wrote:
>> unix_dgram_recvmsg() will hold the readlock of the socket until recv
>> is complete.
>>
>> In the same time, we may try to setsockopt(SO_PEEK_OFF) which will hang until
>> unix_dgram_recvmsg() will complete (which can take a while) without allowing
>> us to break out of it, triggering a hung task spew.
>>
>> Instead, allow set_peek_off to fail, this way userspace will not hang.
>>
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
> Acked-by: Pavel Emelyanov <xemul@parallels.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-12-11 2:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 22:26 [PATCH] net: unix: allow set_peek_off to fail Sasha Levin
2013-12-09 7:32 ` Pavel Emelyanov
2013-12-11 2:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210.214546.2076606671956419677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).