From: Wei Liu <wei.liu2@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: <xen-devel@lists.xen.org>, <netdev@vger.kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH net] xen-netback: fix abuse of napi budget
Date: Tue, 10 Dec 2013 10:34:08 +0000 [thread overview]
Message-ID: <20131210103408.GI32155@zion.uk.xensource.com> (raw)
In-Reply-To: <1386670600-5882-1-git-send-email-paul.durrant@citrix.com>
On Tue, Dec 10, 2013 at 10:16:40AM +0000, Paul Durrant wrote:
> netback seemed to be somewhat confused about the napi budget parameter and
> basically ignored it. This patch fixes that, properly limiting the work done
> in each poll.
>
After reading the code I think your "basically ignored it" means netback
will process the ring as much as possible, right?
But overall the packets passed to network stack is still limited by
budget, if I'm not mistaken.
What's the impact on flow control if you more the check earlier?
Wei.
prev parent reply other threads:[~2013-12-10 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 10:16 [PATCH net] xen-netback: fix abuse of napi budget Paul Durrant
2013-12-10 10:25 ` Ian Campbell
2013-12-10 10:30 ` David Vrabel
2013-12-10 10:37 ` Wei Liu
2013-12-10 10:44 ` Wei Liu
2013-12-10 10:48 ` Paul Durrant
2013-12-10 10:55 ` Wei Liu
2013-12-10 11:03 ` Paul Durrant
2013-12-10 10:52 ` Paul Durrant
2013-12-10 10:34 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210103408.GI32155@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).