From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host
Date: Tue, 10 Dec 2013 17:24:29 +0200 [thread overview]
Message-ID: <20131210152429.GB25293@redhat.com> (raw)
In-Reply-To: <20131209161632.5ac96e5a@nehalam.linuxnetplumber.net>
On Mon, Dec 09, 2013 at 04:16:32PM -0800, Stephen Hemminger wrote:
> The virtio_net driver never sends the multicast address list to
> the host. This is because send command takes a pointer to scatter list
> to send but only inserts that one entry into the outgoing scatter list.
>
> This bug has been there since:
> commit f565a7c259d71cc186753653d978c646d2354b36
> Author: Alex Williamson <alex.williamson@hp.com>
> Date: Wed Feb 4 09:02:45 2009 +0000
>
> virtio_net: Add a MAC filter table
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Question is, can we detect a broken driver in the host somehow?
If not we'll need a feature bit for hosts to actually do
MC filtering.
> --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800
> +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800
> @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct
> sg_init_one(&hdr, &ctrl, sizeof(ctrl));
> sgs[out_num++] = &hdr;
>
> - if (out)
> + for (; out; out = sg_next(out))
> sgs[out_num++] = out;
> if (in)
> sgs[out_num + in_num++] = in;
next prev parent reply other threads:[~2013-12-10 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 0:16 [PATCH net-next 1/3] virtio_net: set multicast filter list to host Stephen Hemminger
2013-12-10 0:17 ` [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command Stephen Hemminger
2013-12-10 15:25 ` Michael S. Tsirkin
2013-12-11 3:28 ` David Miller
2013-12-10 0:18 ` [PATCH net-next 3/3] virtio_net: spelling fixes Stephen Hemminger
2013-12-10 15:25 ` Michael S. Tsirkin
2013-12-11 3:28 ` David Miller
2013-12-10 15:24 ` Michael S. Tsirkin [this message]
2013-12-10 21:07 ` [PATCH net-next 1/3] virtio_net: set multicast filter list to host Michael S. Tsirkin
2013-12-10 17:40 ` Vlad Yasevich
2013-12-11 3:28 ` David Miller
2013-12-12 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210152429.GB25293@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).