netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 1/3] virtio_net: set multicast filter list to host
@ 2013-12-10  0:16 Stephen Hemminger
  2013-12-10  0:17 ` [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command Stephen Hemminger
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Stephen Hemminger @ 2013-12-10  0:16 UTC (permalink / raw)
  To: David Miller, Rusty Russell, Michael S. Tsirkin; +Cc: virtualization, netdev

The virtio_net driver never sends the multicast address list to
the host. This is because send command takes a pointer to scatter list
to send but only inserts that one entry into the outgoing scatter list.

This bug has been there since:
commit f565a7c259d71cc186753653d978c646d2354b36
Author: Alex Williamson <alex.williamson@hp.com>
Date:   Wed Feb 4 09:02:45 2009 +0000

    virtio_net: Add a MAC filter table

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--- a/drivers/net/virtio_net.c	2013-12-09 16:12:03.897891975 -0800
+++ b/drivers/net/virtio_net.c	2013-12-09 16:12:36.353164803 -0800
@@ -893,7 +893,7 @@ static bool virtnet_send_command(struct
 	sg_init_one(&hdr, &ctrl, sizeof(ctrl));
 	sgs[out_num++] = &hdr;
 
-	if (out)
+	for (; out; out = sg_next(out))
 		sgs[out_num++] = out;
 	if (in)
 		sgs[out_num + in_num++] = in;

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2013-12-12 18:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-10  0:16 [PATCH net-next 1/3] virtio_net: set multicast filter list to host Stephen Hemminger
2013-12-10  0:17 ` [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command Stephen Hemminger
2013-12-10 15:25   ` Michael S. Tsirkin
2013-12-11  3:28   ` David Miller
2013-12-10  0:18 ` [PATCH net-next 3/3] virtio_net: spelling fixes Stephen Hemminger
2013-12-10 15:25   ` Michael S. Tsirkin
2013-12-11  3:28   ` David Miller
2013-12-10 15:24 ` [PATCH net-next 1/3] virtio_net: set multicast filter list to host Michael S. Tsirkin
2013-12-10 21:07   ` Michael S. Tsirkin
2013-12-10 17:40 ` Vlad Yasevich
2013-12-11  3:28 ` David Miller
2013-12-12 18:26 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).