Re: [PATCH net-next v3] ipv4: fix wildcard search with inet_confirm_addr()

[David Miller <davem@davemloft.net>]

From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Tue, 10 Dec 2013 15:02:40 +0100

> 39a6d0630012 ("[NETNS]: Process inet_confirm_addr in the
> correct namespace."), the code supposes that it will never be NULL. This
> function is never called with in_dev == NULL, but it's exported and may be used
> by an external module.
> 
> Because this patch restore the ability to call inet_confirm_addr() with in_dev
> == NULL, I partially revert the above commit, as suggested by Julian.
> 
> CC: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Reviewed-by: Julian Anastasov <ja@ssi.bg>

I personally think that we may be over analyzing this, because if some
external module actually cared, someone would have complained in the
last _5_ years as that's how long the new semantics have been in
place.

Nevertheless, passing in the network namespace explicitly is a bit
nicer than having special behavior for RT_SCOPE_LINE, thus I've
applied this.

Thanks.