From: David Miller <davem@davemloft.net>
To: paul.durrant@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org,
wei.liu2@citrix.com, ian.campbell@citrix.com,
david.vrabel@citrix.com
Subject: Re: [PATCH net] xen-netback: make sure skb linear area covers checksum field
Date: Wed, 11 Dec 2013 16:47:16 -0500 (EST) [thread overview]
Message-ID: <20131211.164716.1397098528848980750.davem@davemloft.net> (raw)
In-Reply-To: <1386779860-19338-1-git-send-email-paul.durrant@citrix.com>
From: Paul Durrant <paul.durrant@citrix.com>
Date: Wed, 11 Dec 2013 16:37:40 +0000
> skb_partial_csum_set requires that the linear area of the skb covers the
> checksum field. The checksum setup code in netback was only doing that
> pullup in the case when the pseudo header checksum was being recalculated
> though. This patch makes that pullup unconditional. (I pullup the whole
> transport header just for simplicity; the requirement is only for the check
> field but in the case of UDP this is the last field in the header and in the
> case of TCP it's the last but one).
>
> The lack of pullup manifested as failures running Microsoft HCK network
> tests on a pair of Windows 8 VMs and it has been verified that this patch
> fixes the problem.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Applied, thank you.
prev parent reply other threads:[~2013-12-11 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 16:37 [PATCH net] xen-netback: make sure skb linear area covers checksum field Paul Durrant
2013-12-11 16:47 ` [Xen-devel] " Jan Beulich
2013-12-11 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211.164716.1397098528848980750.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).