From: David Miller <davem@davemloft.net>
To: tedheadster@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature
Date: Wed, 11 Dec 2013 17:12:24 -0500 (EST) [thread overview]
Message-ID: <20131211.171224.2111686395095015308.davem@davemloft.net> (raw)
In-Reply-To: <1386799259-31623-1-git-send-email-tedheadster@gmail.com>
From: Matthew Whitehead <tedheadster@gmail.com>
Date: Wed, 11 Dec 2013 17:00:59 -0500
> Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
> the private struct ei_device. Now each 8390 ethernet instance has a per-device
> logging variable.
>
> Changed older style printk() calls to more canonical forms.
>
> Tested on: ne, ne2k-pci, smc-ultra, and wd hardware.
>
> V4.0
> - Substituted pr_info() and pr_debug() for printk() KERN_INFO and KERN_DEBUG
>
> V3.0
> - Checked for cases where pr_cont() was most appropriate choice.
> - Changed module parameter from 'debug' to 'msg_enable' because debug was
> no longer the best description.
>
> V2.0
> - Changed netif_msg_(drv|probe|ifdown|rx_err|tx_err|tx_queued|intr|rx_status|hw)
> to netif_(dbg|info|warn|err) where possible.
>
> Signed-off-by: Matthew Whitehead <tedheadster@gmail.com>
Applied, but there was some trailing whitespace I had to edit out while
applying this, thanks.
prev parent reply other threads:[~2013-12-11 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 22:00 [PATCH v4 net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature Matthew Whitehead
2013-12-11 22:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211.171224.2111686395095015308.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tedheadster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).