From: David Miller <davem@davemloft.net>
To: qais.yousef@imgtec.com
Cc: yangyingliang@huawei.com, edumazet@google.com, jhs@mojatatu.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] net/sched/sch_tbf.c: fix linking error
Date: Thu, 12 Dec 2013 12:25:42 -0500 (EST) [thread overview]
Message-ID: <20131212.122542.1538675820432940524.davem@davemloft.net> (raw)
In-Reply-To: <1386851936-1582-1-git-send-email-qais.yousef@imgtec.com>
From: Qais Yousef <qais.yousef@imgtec.com>
Date: Thu, 12 Dec 2013 12:38:56 +0000
> ERROR: "__udivdi3" [net/sched/sch_tbf.ko] undefined!
>
> introduced by: cc106e441a63 (net: sched: tbf: fix the calculation of max_size)
>
> which adds a 64 by 32 bit division without using do_div().
> Fix it by using do_div(len/ 53) instead of len/53.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-next@vger.kernel.org
> ---
> We caught this error on linux-next today. This is my quick attemp of a fix.
> If it's not appropriate or doesn't make sense my apologies and feel free to
> resend a better fix :)
This is already fixed in the net-next tree.
next prev parent reply other threads:[~2013-12-12 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 12:38 [PATCH] net/sched/sch_tbf.c: fix linking error Qais Yousef
2013-12-12 14:18 ` Eric Dumazet
2013-12-12 14:29 ` Qais Yousef
2013-12-12 17:25 ` David Miller [this message]
[not found] <1386851356-1395-1-git-send-email-qais.yousef@imgtec.com>
2013-12-16 13:34 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212.122542.1538675820432940524.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qais.yousef@imgtec.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).