netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vyasevich@gmail.com
Cc: dvlasenk@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	jpirko@redhat.com
Subject: Re: [patch net-next v2] ipv6: log autoconfiguration failures
Date: Thu, 12 Dec 2013 13:24:41 -0500 (EST)	[thread overview]
Message-ID: <20131212.132441.1907656115241279246.davem@davemloft.net> (raw)
In-Reply-To: <52A9F93A.5040104@gmail.com>

From: Vlad Yasevich <vyasevich@gmail.com>
Date: Thu, 12 Dec 2013 12:58:18 -0500

> On 12/12/2013 12:22 PM, David Miller wrote:
>> Give it statistics just like we have for every other kind of similar
>> event.
> 
> The fact that link-local address could not be generated for a specific
> device type does not lend itself well to counting.  There is no way
> from to tell from the counter which device does not support IPv6 autoconfig.

If the statistic is per-device, which I recommended it be implemented as,
you indeed can.

And I do not buy the argument that this is "useless" because the admin
is just going to kill the interface and create a new one.  When you
notice there is a problem, you look at the statistics before doing
that!

  reply	other threads:[~2013-12-12 18:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 11:45 [patch net-next v2] ipv6: log autoconfiguration failures Denys Vlasenko
2013-12-11 19:21 ` Hannes Frederic Sowa
2013-12-11 20:54   ` David Miller
2013-12-11 21:09     ` Hannes Frederic Sowa
2013-12-12 11:28     ` Denys Vlasenko
2013-12-12 17:24       ` David Miller
2013-12-12 11:17   ` Denys Vlasenko
2013-12-12 17:22     ` David Miller
2013-12-12 17:58       ` Vlad Yasevich
2013-12-12 18:24         ` David Miller [this message]
2013-12-12 19:00           ` Hannes Frederic Sowa
2013-12-12 19:06             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212.132441.1907656115241279246.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dvlasenk@redhat.com \
    --cc=jmorris@namei.org \
    --cc=jpirko@redhat.com \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).