netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: rusty@rustcorp.com.au, mst@redhat.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host
Date: Thu, 12 Dec 2013 13:26:17 -0500 (EST)	[thread overview]
Message-ID: <20131212.132617.1255637880637039918.davem@davemloft.net> (raw)
In-Reply-To: <20131209161632.5ac96e5a@nehalam.linuxnetplumber.net>

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 9 Dec 2013 16:16:32 -0800

> The virtio_net driver never sends the multicast address list to
> the host. This is because send command takes a pointer to scatter list
> to send but only inserts that one entry into the outgoing scatter list.
> 
> This bug has been there since:
> commit f565a7c259d71cc186753653d978c646d2354b36
> Author: Alex Williamson <alex.williamson@hp.com>
> Date:   Wed Feb 4 09:02:45 2009 +0000
> 
>     virtio_net: Add a MAC filter table
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

I'm just going to assume for now that you agree with the anaylsis of
others that the sg lists are processed properly as-is, and therefore
your patch isn't necessary.

Let me know if that is not the case.

Thanks.

      parent reply	other threads:[~2013-12-12 18:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10  0:16 [PATCH net-next 1/3] virtio_net: set multicast filter list to host Stephen Hemminger
2013-12-10  0:17 ` [PATCH net-next 2/3] virtio_net: remove unused parameter to send_command Stephen Hemminger
2013-12-10 15:25   ` Michael S. Tsirkin
2013-12-11  3:28   ` David Miller
2013-12-10  0:18 ` [PATCH net-next 3/3] virtio_net: spelling fixes Stephen Hemminger
2013-12-10 15:25   ` Michael S. Tsirkin
2013-12-11  3:28   ` David Miller
2013-12-10 15:24 ` [PATCH net-next 1/3] virtio_net: set multicast filter list to host Michael S. Tsirkin
2013-12-10 21:07   ` Michael S. Tsirkin
2013-12-10 17:40 ` Vlad Yasevich
2013-12-11  3:28 ` David Miller
2013-12-12 18:26 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212.132617.1255637880637039918.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=stephen@networkplumber.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).