Re: [PATCH net-next] bridge: allow local delivery when port is disabled

[David Miller <davem@davemloft.net>]

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 12 Dec 2013 13:41:59 -0800

> When an Ethernet device is enslaved to a bridge, and the bridge STP
> detects loss of carrier (or operational state down), then normally
> packet reception is blocked.
> 
> This breaks control applications like WPA which maybe expecting to
> receive packets to negotiate to bring link up. The bridge needs to
> block forwarding packets from these disabled ports, but there is no
> hard requirement to not allow local packet delivery.
> 
> In this special case, packets are not forwarded (local delivery only),
> and only packet directed at the address of the Ethernet device are
> accepted (no promiscuous or other ports in bridge).
> 
> The existing code already allowed link-local-address packets in
> which is what STP uses to communicate with other bridges.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>

I think this change needs to be more careful about the setting of
*pskb.  It should not be assigned if we return RX_HANDLER_CONSUMED.