From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bridge: allow local delivery when port is disabled
Date: Thu, 12 Dec 2013 23:52:28 -0500 (EST) [thread overview]
Message-ID: <20131212.235228.1750048814040164603.davem@davemloft.net> (raw)
In-Reply-To: <20131212150523.3c2abeca@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 12 Dec 2013 15:05:23 -0800
> On Thu, 12 Dec 2013 17:26:37 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Date: Thu, 12 Dec 2013 13:41:59 -0800
>>
>> > When an Ethernet device is enslaved to a bridge, and the bridge STP
>> > detects loss of carrier (or operational state down), then normally
>> > packet reception is blocked.
>> >
>> > This breaks control applications like WPA which maybe expecting to
>> > receive packets to negotiate to bring link up. The bridge needs to
>> > block forwarding packets from these disabled ports, but there is no
>> > hard requirement to not allow local packet delivery.
>> >
>> > In this special case, packets are not forwarded (local delivery only),
>> > and only packet directed at the address of the Ethernet device are
>> > accepted (no promiscuous or other ports in bridge).
>> >
>> > The existing code already allowed link-local-address packets in
>> > which is what STP uses to communicate with other bridges.
>> >
>> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> > Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>>
>> I think this change needs to be more careful about the setting of
>> *pskb. It should not be assigned if we return RX_HANDLER_CONSUMED.
>
> It was already in the existing code path for link local.
That's not true, the "*pskb = skb;" assignment was only done when the
code retuned RX_HANDLER_PASS. You are changing it to unconditionally
make this assignment.
prev parent reply other threads:[~2013-12-13 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 21:41 [PATCH net-next] bridge: allow local delivery when port is disabled Stephen Hemminger
2013-12-12 22:26 ` David Miller
2013-12-12 23:05 ` Stephen Hemminger
2013-12-13 4:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212.235228.1750048814040164603.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).