From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Daniel Borkmann <dborkman@redhat.com>,
NetDev <netdev@vger.kernel.org>,
brouer@redhat.com, davem@davemloft.net
Subject: Re: [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code
Date: Thu, 12 Dec 2013 08:19:51 +0100 [thread overview]
Message-ID: <20131212081951.23e3f9ea@redhat.com> (raw)
In-Reply-To: <1386888664.2586.3.camel@ThinkPad-T5421>
On Fri, 13 Dec 2013 06:51:04 +0800
Li Zhong <zhong@linux.vnet.ibm.com> wrote:
> This patches tries to fix the following warning on next-1211 by
> replacing smp_processor_id() with raw_smp_processor_id().
>
> [ 11.120893] BUG: using smp_processor_id() in preemptible [00000000] code: arping/3510
> [ 11.120913] caller is .packet_sendmsg+0xc14/0xe68
> [ 11.120920] CPU: 13 PID: 3510 Comm: arping Not tainted 3.13.0-rc3-next-20131211-dirty #1
> [ 11.120926] Call Trace:
> [ 11.120932] [c0000001f803f6f0] [c0000000000138dc] .show_stack+0x110/0x25c (unreliable)
> [ 11.120942] [c0000001f803f7e0] [c00000000083dd24] .dump_stack+0xa0/0x37c
> [ 11.120951] [c0000001f803f870] [c000000000493fd4] .debug_smp_processor_id+0xfc/0x12c
> [ 11.120959] [c0000001f803f900] [c0000000007eba78] .packet_sendmsg+0xc14/0xe68
> [ 11.120968] [c0000001f803fa80] [c000000000700968] .sock_sendmsg+0xa0/0xe0
> [ 11.120975] [c0000001f803fbf0] [c0000000007014d8] .SyS_sendto+0x100/0x148
> [ 11.120983] [c0000001f803fd60] [c0000000006fff10] .SyS_socketcall+0x1c4/0x2e8
> [ 11.120990] [c0000001f803fe30] [c00000000000a1e4] syscall_exit+0x0/0x9c
>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
> ---
> v2: as Daniel suggested, removed the part about setting queue_mapping
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2013-12-12 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386828604.2584.13.camel@ThinkPad-T5421>
[not found] ` <52A83699.9010504@redhat.com>
2013-12-12 22:51 ` [PATCH v2 net-next] packet: fix using smp_processor_id() in preemptible code Li Zhong
2013-12-12 7:19 ` Jesper Dangaard Brouer [this message]
2013-12-12 7:29 ` Daniel Borkmann
2013-12-12 21:15 ` David Miller
2013-12-13 1:49 ` Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212081951.23e3f9ea@redhat.com \
--to=jbrouer@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).