From: Steffen Klassert <steffen.klassert@secunet.com>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] xfrm: Increase the garbage collector threshold
Date: Fri, 13 Dec 2013 11:12:03 +0100 [thread overview]
Message-ID: <20131213101203.GO31491@secunet.com> (raw)
In-Reply-To: <1386686323.22947.26.camel@sakura.staff.proxad.net>
On Tue, Dec 10, 2013 at 03:38:43PM +0100, Maxime Bizon wrote:
>
> On Fri, 2013-11-01 at 09:21 +0100, Steffen Klassert wrote:
>
> Hello Steffen,
>
> > It turned out that the current threshold before we
> > start garbage collecting is much to small for some
> > workloads, so increase it from 1024 to 32768. This
> > means that we start the garbage collector if we have
> > more than 32768 dst entries in the system and refuse
> > new allocations if we are above 65536.
>
> sorry to dig an old thread, but could you please explain the lifetime of
> those dst entries ?
>
> After basic tests it seems the ipv4 dst entry needs to be released first
> before the xfrm dst can be released by gc.
>
Can you please be a bit more precise with your problem description?
This patch changes only the number of cache entries before
we start garbage collecting. It does not change anything
on the garbage collector itself.
next prev parent reply other threads:[~2013-12-13 10:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 8:21 pull request (net): ipsec 2013-11-01 Steffen Klassert
2013-11-01 8:21 ` [PATCH 1/3] xfrm: prevent ipcomp scratch buffer race condition Steffen Klassert
2013-11-01 8:21 ` [PATCH 2/3] xfrm: Increase the garbage collector threshold Steffen Klassert
2013-12-10 14:38 ` Maxime Bizon
2013-12-13 10:12 ` Steffen Klassert [this message]
2013-12-13 16:13 ` Maxime Bizon
2013-12-16 11:51 ` Steffen Klassert
2013-12-16 14:29 ` Maxime Bizon
2013-11-01 8:21 ` [PATCH 3/3] xfrm: Fix null pointer dereference when decoding sessions Steffen Klassert
2013-11-24 14:27 ` Matthias Schiffer
2013-12-01 4:19 ` Matthias Schiffer
2013-12-02 1:35 ` David Miller
2013-12-03 9:56 ` Steffen Klassert
2013-12-03 10:37 ` Wolfgang Walter
2013-12-03 10:41 ` Hannes Frederic Sowa
2013-12-05 21:35 ` David Miller
2013-11-02 5:22 ` pull request (net): ipsec 2013-11-01 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213101203.GO31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).