netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] bnad: make local variable static
@ 2013-12-14  0:40 Stephen Hemminger
  2013-12-14  1:34 ` Rasesh Mody
  2013-12-17 20:19 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2013-12-14  0:40 UTC (permalink / raw)
  To: Rasesh Mody, David Miller; +Cc: netdev

Compile tested only.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--- a/drivers/net/ethernet/brocade/bna/bnad.c	2013-12-12 11:48:17.033855594 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad.c	2013-12-12 11:56:57.325752730 -0800
@@ -52,7 +52,7 @@ MODULE_PARM_DESC(bna_debugfs_enable, "En
 /*
  * Global variables
  */
-u32 bnad_rxqs_per_cq = 2;
+static u32 bnad_rxqs_per_cq = 2;
 static u32 bna_id;
 static struct mutex bnad_list_mutex;
 static LIST_HEAD(bnad_list);
--- a/drivers/net/ethernet/brocade/bna/bnad.h	2013-12-12 11:48:17.033855594 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad.h	2013-12-12 11:56:57.325752730 -0800
@@ -367,7 +367,6 @@ struct bnad_drvinfo {
  * EXTERN VARIABLES
  */
 extern const struct firmware *bfi_fw;
-extern u32		bnad_rxqs_per_cq;
 
 /*
  * EXTERN PROTOTYPES

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH net-next] bnad: make local variable static
  2013-12-14  0:40 [PATCH net-next] bnad: make local variable static Stephen Hemminger
@ 2013-12-14  1:34 ` Rasesh Mody
  2013-12-17 20:19 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Rasesh Mody @ 2013-12-14  1:34 UTC (permalink / raw)
  To: Stephen Hemminger, David Miller; +Cc: netdev@vger.kernel.org

>From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>Sent: Friday, December 13, 2013 4:40 PM
>
>Compile tested only.

Thanks Stephen!

Sanity and basic traffic test conducted and it looks fine.

Acked-by: Rasesh Mody <rmody@brocade.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] bnad: make local variable static
  2013-12-14  0:40 [PATCH net-next] bnad: make local variable static Stephen Hemminger
  2013-12-14  1:34 ` Rasesh Mody
@ 2013-12-17 20:19 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-17 20:19 UTC (permalink / raw)
  To: stephen; +Cc: rmody, netdev

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 13 Dec 2013 16:40:10 -0800

> Compile tested only.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-17 20:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14  0:40 [PATCH net-next] bnad: make local variable static Stephen Hemminger
2013-12-14  1:34 ` Rasesh Mody
2013-12-17 20:19 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).