netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: hkchu@google.com, edumazet@google.com,
	herbert@gondor.apana.org.au, ogerlitz@mellanox.com,
	bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: fix compiler warning in ipv6_exthdrs_len
Date: Sat, 14 Dec 2013 02:02:11 -0500 (EST)	[thread overview]
Message-ID: <20131214.020211.969354536190248209.davem@davemloft.net> (raw)
In-Reply-To: <20131214062929.GA23563@order.stressinduktion.org>

From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 14 Dec 2013 07:29:29 +0100

> Commit 299603e8370a93dd5d8e8d800f0dff1ce2c53d36 ("net-gro: Prepare GRO
> stack for the upcoming tunneling support") used an uninitialized variable
> which leads to the following compiler warning:
> 
> net/ipv6/ip6_offload.c: In function ‘ipv6_gro_complete’:
> net/ipv6/ip6_offload.c:178:24: warning: ‘optlen’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     opth = (void *)opth + optlen;
>                         ^
> net/ipv6/ip6_offload.c:164:22: note: ‘optlen’ was declared here
>   int len = 0, proto, optlen;
>                       ^
> Fix it up.
> 
> Cc: Jerry Chu <hkchu@google.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Applied.

  reply	other threads:[~2013-12-14  7:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  4:53 [PATCH v3 net-next] net-gro: Prepare GRO stack for the upcoming tunneling support H.K. Jerry Chu
2013-12-12 18:48 ` David Miller
2013-12-12 23:48   ` Jerry Chu
2013-12-14  6:29 ` [PATCH net-next] ipv6: fix compiler warning in ipv6_exthdrs_len Hannes Frederic Sowa
2013-12-14  7:02   ` David Miller [this message]
2013-12-15 16:20     ` Jerry Chu
2013-12-15 17:18       ` [PATCH net-next] ipv6: revert misguided compiler warning fix on ipv6_exthdrs_len Hannes Frederic Sowa
2013-12-15 17:23         ` Hannes Frederic Sowa
2013-12-16  1:31           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131214.020211.969354536190248209.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=edumazet@google.com \
    --cc=hannes@stressinduktion.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=hkchu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).