From: David Miller <davem@davemloft.net>
To: hkchu@google.com
Cc: hannes@stressinduktion.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net-ipv6: Fix alleged compiler warning in ipv6_exthdrs_len()
Date: Sun, 15 Dec 2013 20:31:58 -0500 (EST) [thread overview]
Message-ID: <20131215.203158.557626779911420893.davem@davemloft.net> (raw)
In-Reply-To: <1387127947-2075-1-git-send-email-hkchu@google.com>
From: "H.K. Jerry Chu" <hkchu@google.com>
Date: Sun, 15 Dec 2013 09:19:07 -0800
> From: Jerry Chu <hkchu@google.com>
>
> It was reported that Commit 299603e8370a93dd5d8e8d800f0dff1ce2c53d36
> ("net-gro: Prepare GRO stack for the upcoming tunneling support")
> triggered a compiler warning in ipv6_exthdrs_len():
>
> net/ipv6/ip6_offload.c: In function ‘ipv6_gro_complete’:
> net/ipv6/ip6_offload.c:178:24: warning: ‘optlen’ may be used uninitialized in this function [-Wmaybe-u
> opth = (void *)opth + optlen;
> ^
> net/ipv6/ip6_offload.c:164:22: note: ‘optlen’ was declared here
> int len = 0, proto, optlen;
> ^
> Note that there was no real bug here - optlen was never uninitialized
> before use. (Was the version of gcc I used smarter to not complain?)
>
> Reported-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: H.K. Jerry Chu <hkchu@google.com>
What is this patch against?
It gets rejects when I try to apply it both with Hannes's patch reverted
and without it reverted.
next prev parent reply other threads:[~2013-12-16 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 17:19 [PATCH net-next] net-ipv6: Fix alleged compiler warning in ipv6_exthdrs_len() H.K. Jerry Chu
2013-12-16 1:31 ` David Miller [this message]
2013-12-16 2:30 ` Jerry Chu
-- strict thread matches above, loose matches on Subject: below --
2013-12-16 2:48 H.K. Jerry Chu
2013-12-16 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131215.203158.557626779911420893.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).