From: David Miller <davem@davemloft.net>
To: speiro@ai2.upv.es
Cc: linux-kernel@vger.kernel.org, security@kernel.org,
linux-hams@vger.kernel.org, netdev@vger.kernel.org,
jpr@f6fbb.org, stable@vger.kernel.org
Subject: Re: [PATCH] hamradio/yam: fix info leak in ioctl
Date: Mon, 16 Dec 2013 20:11:27 -0500 (EST) [thread overview]
Message-ID: <20131216.201127.533912619440960142.davem@davemloft.net> (raw)
In-Reply-To: <1386920767-27962-1-git-send-email-speiro@ai2.upv.es>
From: Salva Peiró <speiro@ai2.upv.es>
Date: Fri, 13 Dec 2013 08:46:07 +0100
> The yam_ioctl() code fails to initialise the cmd field
> of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
> before filling the structure to avoid the 4-byte info leak.
>
> Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Put this into the SIOCYAMGCFG case statement, which is where the
problem actually exists.
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-17 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 7:46 [PATCH] hamradio/yam: fix info leak in ioctl Salva Peiró
2013-12-17 1:11 ` David Miller [this message]
2013-12-17 9:06 ` [PATCH v2] " Salva Peiró
2013-12-19 20:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216.201127.533912619440960142.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpr@f6fbb.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=speiro@ai2.upv.es \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).