From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether
Date: Mon, 16 Dec 2013 10:30:54 +0900 [thread overview]
Message-ID: <20131216013054.GA3192@verge.net.au> (raw)
In-Reply-To: <52AE11A7.6090407@cogentembedded.com>
On Sun, Dec 15, 2013 at 11:31:35PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/15/2013 11:24 AM, Simon Horman wrote:
>
> You forgot to sign off.
>
> [...]
>
> >diff --git a/arch/arm/mach-shmobile/board-genmai.c b/arch/arm/mach-shmobile/board-genmai.c
> >index 3e92e3c..838325b 100644
> >--- a/arch/arm/mach-shmobile/board-genmai.c
> >+++ b/arch/arm/mach-shmobile/board-genmai.c
> >@@ -20,15 +20,35 @@
> >
> > #include <linux/kernel.h>
> > #include <linux/platform_device.h>
> >+#include <linux/sh_eth.h>
> > #include <mach/common.h>
> >+#include <mach/irqs.h>
> > #include <mach/r7s72100.h>
> > #include <asm/mach-types.h>
> > #include <asm/mach/arch.h>
> >
> >+/* GEther */
> >+static const struct sh_eth_plat_data gether_pdata __initconst = {
> >+ .phy = 0x00, /* PD60610 */
> >+ .edmac_endian = EDMAC_LITTLE_ENDIAN,
> >+ .phy_interface = PHY_INTERFACE_MODE_MII,
>
> Does MII work for Gigabit Ethernet?
My understanding is that although the SH ethernet block on
the SoC supports Gigabit it is only wired up to allow 100Mbit
access on the board and that MII is the interface used.
I believe this is the same situation as the Armadillo 800 EVA board.
next prev parent reply other threads:[~2013-12-16 1:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 8:24 [PATCH RFC 0/3] Add ethernet support for r7s72100 Simon Horman
2013-12-15 8:24 ` [PATCH RFC net-next 1/3] [RFC] sh_eth: Add " Simon Horman
2013-12-24 21:25 ` Sergei Shtylyov
2013-12-15 8:24 ` [PATCH RFC 2/3] [RFC] ARM: shmobile: r7s72100: Add clock for r7s72100-gether Simon Horman
2013-12-15 20:18 ` Sergei Shtylyov
2013-12-16 1:31 ` Simon Horman
2013-12-15 8:24 ` [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether Simon Horman
2013-12-15 20:31 ` Sergei Shtylyov
2013-12-16 1:30 ` Simon Horman [this message]
2013-12-24 21:43 ` Sergei Shtylyov
2013-12-24 21:45 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216013054.GA3192@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).