From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether Date: Mon, 16 Dec 2013 10:30:54 +0900 Message-ID: <20131216013054.GA3192@verge.net.au> References: <1387095886-15163-1-git-send-email-horms+renesas@verge.net.au> <1387095886-15163-4-git-send-email-horms+renesas@verge.net.au> <52AE11A7.6090407@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm To: Sergei Shtylyov Return-path: Content-Disposition: inline In-Reply-To: <52AE11A7.6090407@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Dec 15, 2013 at 11:31:35PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/15/2013 11:24 AM, Simon Horman wrote: > > You forgot to sign off. > > [...] > > >diff --git a/arch/arm/mach-shmobile/board-genmai.c b/arch/arm/mach-shmobile/board-genmai.c > >index 3e92e3c..838325b 100644 > >--- a/arch/arm/mach-shmobile/board-genmai.c > >+++ b/arch/arm/mach-shmobile/board-genmai.c > >@@ -20,15 +20,35 @@ > > > > #include > > #include > >+#include > > #include > >+#include > > #include > > #include > > #include > > > >+/* GEther */ > >+static const struct sh_eth_plat_data gether_pdata __initconst = { > >+ .phy = 0x00, /* PD60610 */ > >+ .edmac_endian = EDMAC_LITTLE_ENDIAN, > >+ .phy_interface = PHY_INTERFACE_MODE_MII, > > Does MII work for Gigabit Ethernet? My understanding is that although the SH ethernet block on the SoC supports Gigabit it is only wired up to allow 100Mbit access on the board and that MII is the interface used. I believe this is the same situation as the Armadillo 800 EVA board.