From: Richard Cochran <richardcochran@gmail.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Darren Hart <dvhart@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Joe Perches <joe@perches.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Veaceslav Falico <vfalico@redhat.com>,
netdev@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c
Date: Mon, 16 Dec 2013 09:58:40 +0100 [thread overview]
Message-ID: <20131216085839.GA8303@netboy> (raw)
In-Reply-To: <1387140255-11797-1-git-send-email-rashika.kheria@gmail.com>
On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote:
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 9 ---------
> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 +
> drivers/ptp/ptp_pch.c | 1 +
> include/linux/ptp_pch.h | 16 ++++++++++++++++
> 4 files changed, 18 insertions(+), 9 deletions(-)
> create mode 100644 include/linux/ptp_pch.h
Instead of adding a random driver header into include/linux, I would
prefer that you just move the ptp_pch.c from drivers/ptp to
drivers/net/ethernet/oki-semi/pch_gbe. Then you can just include
pch_gbe.h directly.
Thanks,
Richard
next prev parent reply other threads:[~2013-12-16 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 20:44 [PATCH] drivers: ptp: Include new header file in ptp_pch.c Rashika Kheria
2013-12-15 21:01 ` Josh Triplett
2013-12-16 8:58 ` Richard Cochran [this message]
2013-12-18 22:43 ` David Miller
2013-12-18 23:40 ` josh
2013-12-19 7:27 ` Richard Cochran
2013-12-19 19:13 ` Ben Hutchings
2013-12-19 19:23 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216085839.GA8303@netboy \
--to=richardcochran@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).