netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Atzm Watanabe <atzm@stratosphere.co.jp>
Cc: netdev@vger.kernel.org,
	"Ben Hutchings" <bhutchings@solarflare.com>,
	"David Miller" <davem@davemloft.net>,
	"Daniel Borkmann" <dborkman@redhat.com>,
	"David Laight" <David.Laight@ACULAB.COM>
Subject: Re: [PATCH v3 3/3] packet: Deliver VLAN TPID to userspace
Date: Mon, 16 Dec 2013 09:25:09 -0800	[thread overview]
Message-ID: <20131216092509.1b3d76b3@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <87mwk16wpy.wl%atzm@stratosphere.co.jp>

On Mon, 16 Dec 2013 17:12:09 +0900
Atzm Watanabe <atzm@stratosphere.co.jp> wrote:

>  struct tpacket_hdr_variant1 {
>  	__u32	tp_rxhash;
>  	__u32	tp_vlan_tci;
> +	__u32	tp_vlan_tpid;
>  };

Is this safe? Won't you break ABI for existing userspace applications.

  parent reply	other threads:[~2013-12-16 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  8:12 [PATCH v3 3/3] packet: Deliver VLAN TPID to userspace Atzm Watanabe
2013-12-16 10:18 ` Daniel Borkmann
2013-12-16 12:41   ` Atzm Watanabe
2013-12-16 17:25 ` Stephen Hemminger [this message]
2013-12-17  5:51   ` Atzm Watanabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216092509.1b3d76b3@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=David.Laight@ACULAB.COM \
    --cc=atzm@stratosphere.co.jp \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).