public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Yuchung Cheng <ycheng@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>, Julian Anastasov <ja@ssi.bg>
Subject: Re: [PATCH 0/4] Make tcp-metrics source-address aware
Date: Mon, 16 Dec 2013 21:01:15 +0100	[thread overview]
Message-ID: <20131216200115.GA15318@cpaasch-mac> (raw)
In-Reply-To: <CAK6E8=e4aQ2qqZ4uBNZBvyYdQ1KER8xashQVAYJoiEUm9sbSew@mail.gmail.com>

On 16/12/13 - 11:53:31, Yuchung Cheng wrote:
> > Agreed, in this case it would be negative. Although I doubt that it happens
> > often that the source changes while the public IP remains the same.
> >
> > But for the WiFi/3G-case it is really bad that parameters like
> > ssthresh/rtt/... are kept the same. We will exit slow-start too early when
> > going from WiFi to 3G because ssthresh is too low.
> >
> > What if we copy the fast-open cookie across the different src/dst tcp_metrics-pairs
> > to handle Yuchung's case?
> > Or, maybe get rid of ssthresh/rtt/... in tcp-metrics? But that would probably be too
> > agressive...
> +1 to get rid of ssthresh caching. It often hurts than helps and
> cubic-hystart already mitigates the SS overshoot. See sec 6.2.4 in a
> recent research study
> http://conferences.sigcomm.org/co-next/2013/program/p303.pdf

I haven't yet read the paper, but in their presentation at CoNEXT they said
that the biggest impact comes from spurious retransmission timeouts and the
subsequent cwnd reduction. I would have thought that the cwnd-reduction
undo-procedure covers this case.

> The only case caching RTT could help is the init RTO. But it's unclear
> adding src-ip along will help like DM said.
> 
> Another metric that may have negative effect is reordering metrics.

So, let's get rid of all these metrics (except for TFO)? ;)


Christoph

  reply	other threads:[~2013-12-16 20:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15 12:10 [PATCH 0/4] Make tcp-metrics source-address aware Christoph Paasch
2013-12-15 12:10 ` [PATCH 1/4] tcp: metrics: rename tcpm_addr to tcpm_daddr Christoph Paasch
2013-12-15 12:10 ` [PATCH 2/4] tcp: metrics: Add source-address to tcp-metrics Christoph Paasch
2013-12-15 12:10 ` [PATCH 3/4] tcp: metrics: Delete all entries matching a certain destination Christoph Paasch
2013-12-17 19:57   ` David Miller
2013-12-18  9:58     ` Christoph Paasch
2014-01-02  9:18     ` Christoph Paasch
2014-01-06 21:10       ` David Miller
2013-12-15 12:10 ` [PATCH 4/4] tcp: metrics: Dump info of the source-address in netlink-reply Christoph Paasch
2013-12-15 18:40 ` [PATCH 0/4] Make tcp-metrics source-address aware Eric Dumazet
2013-12-16 18:45   ` Yuchung Cheng
2013-12-16 19:30     ` Christoph Paasch
2013-12-16 19:53       ` Yuchung Cheng
2013-12-16 20:01         ` Christoph Paasch [this message]
2013-12-17 19:56         ` David Miller
2013-12-16  1:45 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216200115.GA15318@cpaasch-mac \
    --to=christoph.paasch@uclouvain.be \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox