From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, fengguang.wu@intel.com
Subject: Re: [PATCH] udp: ipv4: do not use sk_dst_lock from softirq context
Date: Tue, 17 Dec 2013 14:51:16 -0500 (EST) [thread overview]
Message-ID: <20131217.145116.186884795918524348.davem@davemloft.net> (raw)
In-Reply-To: <1387133626.19078.216.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 15 Dec 2013 10:53:46 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Using sk_dst_lock from softirq context is not supported right now.
>
> Instead of adding BH protection everywhere,
> udp_sk_rx_dst_set() can instead use xchg(), as suggested
> by David.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Fixes: 975022310233 ("udp: ipv4: must add synchronization in udp_sk_rx_dst_set()")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-12-17 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 18:53 [PATCH] udp: ipv4: do not use sk_dst_lock from softirq context Eric Dumazet
2013-12-17 19:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217.145116.186884795918524348.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).