netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gilligan@aristanetworks.com
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org
Subject: Re: [PATCH] neigh: Netlink notification for administrative NUD state change
Date: Tue, 17 Dec 2013 16:15:01 -0500 (EST)	[thread overview]
Message-ID: <20131217.161501.873058724657031823.davem@davemloft.net> (raw)
In-Reply-To: <52ae21ac.oFg7QoGcVg2CCThY%gilligan@aristanetworks.com>

From: Bob Gilligan <gilligan@aristanetworks.com>
Date: Sun, 15 Dec 2013 13:39:56 -0800

> 
> The neighbour code sends up an RTM_NEWNEIGH netlink notification if
> the NUD state of a neighbour cache entry is changed by a timer (e.g.
> from REACHABLE to STALE), even if the lladdr of the entry has not
> changed.
> 
> But an administrative change to the the NUD state of a neighbour cache
> entry that does not change the lladdr (e.g. via "ip -4 neigh change
> ...  nud ...") does not trigger a netlink notification.  This means
> that netlink listeners will not hear about administrative NUD state
> changes such as from a resolved state to PERMANENT.
> 
> This patch changes the neighbor code to generate an RTM_NEWNEIGH
> message when the NUD state of an entry is changed administratively.
> 
> Signed-off-by: Bob Gilligan <gilligan@aristanetworks.com>

Applied, thanks Bob.

      parent reply	other threads:[~2013-12-17 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15 21:39 [PATCH] neigh: Netlink notification for administrative NUD state change Bob Gilligan
2013-12-16  8:23 ` Nicolas Dichtel
2013-12-17 21:15 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217.161501.873058724657031823.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gilligan@aristanetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).