netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: use interface mtu for determining if packet-too-big should be send
Date: Tue, 17 Dec 2013 16:42:56 -0500 (EST)	[thread overview]
Message-ID: <20131217.164256.473228543329254152.davem@davemloft.net> (raw)
In-Reply-To: <20131216140124.GA5164@order.stressinduktion.org>

From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 16 Dec 2013 15:01:24 +0100

> On Mon, Dec 16, 2013 at 05:49:42AM -0800, Eric Dumazet wrote:
>> On Mon, 2013-12-16 at 09:09 +0100, Hannes Frederic Sowa wrote:
>> > IPv6 forwarding path should also not depend on the path mtu values to
>> > judge if a packet should get dropped and an ICMP PTB should be returned.
>> > 
>> > For the accompanying change in IPv4, have a look at "ipv4: introduce
>> > ip_dst_mtu_secure and protect forwarding path against pmtu spoofing".
>> > 
>> 
>> No commit sha1 (truncated to 12 digits) ?
> 
> The patch is not yet committed.

It's confusing to propose an ipv6 version of an ipv4 patch that hasn't
been integrated yet, please don't do this.

I would suggest instead fo post the ipv4 and ipv6 variants together
when you want me to consider applying them, or to provide them as
a unit for review.

  reply	other threads:[~2013-12-17 21:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  8:09 [PATCH net-next] ipv6: use interface mtu for determining if packet-too-big should be send Hannes Frederic Sowa
2013-12-16 13:49 ` Eric Dumazet
2013-12-16 14:01   ` Hannes Frederic Sowa
2013-12-17 21:42     ` David Miller [this message]
2013-12-17 21:52       ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217.164256.473228543329254152.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).