From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Subject: RTM_DELROUTE on interface going down - when to send?
Date: Tue, 17 Dec 2013 12:05:12 +0100 [thread overview]
Message-ID: <20131217110512.GA11216@unicorn.suse.cz> (raw)
Hello,
one of our customers noticed that when an interface is switched down, no
RTM_DELROUTE message is sent for IPv4 routes being deleted (but there
are RTM_NEWROUTE messages when the interface is switched up). This is
because rather than deleting the routes with fib_table_delete(), they
are flagged with RTNH_F_DEAD in fib_sync_down_dev() and then deleted in
trie_flush_list().
Before I start with the patch, I would like to ask: would it be more
appropriate to send the message when the route is marked as dead or when
it is actually deleted from the trie?
Michal Kubecek
next reply other threads:[~2013-12-17 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 11:05 Michal Kubecek [this message]
2013-12-17 12:11 ` RTM_DELROUTE on interface going down - when to send? Kristian Evensen
2013-12-17 14:01 ` Michal Kubecek
2013-12-18 9:16 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217110512.GA11216@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).