From: Richard Cochran <richardcochran@gmail.com>
To: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: Hadar Hen Zion <hadarh@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Amir Vadai <amirv@mellanox.com>,
netdev@vger.kernel.org, tomk@rgmadvisors.com,
Shawn Bohrer <sbohrer@rgmadvisors.com>
Subject: Re: mlx4_en SIOCSHWTSTAMP cycles the link
Date: Tue, 17 Dec 2013 12:26:08 +0100 [thread overview]
Message-ID: <20131217112606.GA5307@netboy> (raw)
In-Reply-To: <20131216233415.GA17259@sbohrermbp13-local.rgmadvisors.com>
On Mon, Dec 16, 2013 at 05:34:15PM -0600, Shawn Bohrer wrote:
> On Thu, Dec 12, 2013 at 09:28:15AM -0600, Shawn Bohrer wrote:
> > Below is v2. It compiles, and boots, but linuxptp doesn't work yet
> > and I haven't looked into why. I think linuxptp is actually
> > complaining about SIOCSHWTSTAMP not working as expected, but again I
> > haven't really even started debugging yet.
>
> So performing a SIOCSHWTSTAMP on the mlx4_en driver cycles the link:
>
> [ 9463.081330] mlx4_en: p2p1: Changing Time Stamp configuration
> [ 9463.084637] mlx4_en: p2p1: frag:0 - size:1526 prefix:0 align:0 stride:1536
> [ 9463.155533] mlx4_en: p2p1: Link Down
> [ 9466.471169] mlx4_en: p2p1: Link Up
>
> This breaks linuxptp (ptp4l) since it causes all of the already open
> sockets to silently loose their multicast joins. Thus ptp4l sits
> there waiting for multicast PTP packets that aren't going to come.
The ptp4l program should notice this and recover. This happens when
catching the transmission error on the next sync or delay request. (Or
in slave only E2E mode the sockets are closed and reopened after every
announce interval). If this isn't happening, please post to the
linuxptp-users list the details of your setup.
> I hacked around this in ptp4l by performing the ioctl once with the
> hwstamp_ctl program from linuxptp and skipping the ioctl in ptp4l,
> which works, but quite frankly this sucks. I'd love to know if anyone
> has any better ideas on how to make SIOCSHWTSTAMP usable.
>
> After hacking around the SIOCSHWTSTAMP issue I've noticed that ptp4l
> synchronizes the PHC, however there must be another bug somewhere
> because it creates a 35 second offset from the PTP master.
This is the current TAI-UTC offset. Maybe your grand master is serving
UTC instead of the PTP timescale?
Thanks,
Richard
next prev parent reply other threads:[~2013-12-17 11:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 18:24 [PATCH RFC] mlx4_en: Add PTP hardware clock Shawn Bohrer
2013-12-11 18:54 ` Richard Cochran
2013-12-11 21:28 ` Shawn Bohrer
2013-12-12 9:50 ` Hadar Hen Zion
2013-12-12 15:28 ` Shawn Bohrer
2013-12-16 23:34 ` mlx4_en SIOCSHWTSTAMP cycles the link Shawn Bohrer
2013-12-17 11:26 ` Richard Cochran [this message]
2013-12-17 19:54 ` Shawn Bohrer
2013-12-17 11:44 ` Richard Cochran
2013-12-17 12:06 ` tedheadster
2013-12-11 20:47 ` [PATCH RFC] mlx4_en: Add PTP hardware clock Or Gerlitz
2013-12-11 21:23 ` Shawn Bohrer
2013-12-11 21:35 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217112606.GA5307@netboy \
--to=richardcochran@gmail.com \
--cc=amirv@mellanox.com \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sbohrer@rgmadvisors.com \
--cc=shawn.bohrer@gmail.com \
--cc=tomk@rgmadvisors.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).