From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: dingtianhong@huawei.com, andy@greyhouse.net, vfalico@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change()
Date: Wed, 18 Dec 2013 16:53:20 -0500 (EST) [thread overview]
Message-ID: <20131218.165320.513139543099757450.davem@davemloft.net> (raw)
In-Reply-To: <28416.1386973562@death.nxdomain>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 13 Dec 2013 14:26:02 -0800
> Ding Tianhong <dingtianhong@huawei.com> wrote:
>
>>Jay Vosburgh said that the bond_3ad_adapter_speed_changed and
>>bond_3ad_adapter_duplex_changed is called with RTNL only, and
>>the functions will modify the port's information with no further
>>locking, they will not mutex against bond state machine and
>>incoming LACPDU which do not hold RTNL, So I add port lock to
>>protect the port information.
>>
>>But they are not critical bugs, they exist since day one, and till
>>now they have never been hit and reported, because change for speed
>>and duplex is very rare, and will not occur critical problem.
>>
>>The comments in the function is very old, cleanup the comments together.
>
> For entire series:
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Series applied, thanks.
prev parent reply other threads:[~2013-12-18 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 9:29 [PATCH net 0/3] bonding: add port protection for bond_3ad_xxx_change() Ding Tianhong
2013-12-13 22:26 ` Jay Vosburgh
2013-12-18 21:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218.165320.513139543099757450.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).