From: David Miller <davem@davemloft.net>
To: peter@korsgaard.com
Cc: netdev@vger.kernel.org, joseph_chang@davicom.com.tw,
stable@vger.kernel.org
Subject: Re: [PATCH 4/4] dm9601: work around tx fifo sync issue on dm962x
Date: Wed, 18 Dec 2013 17:48:01 -0500 (EST) [thread overview]
Message-ID: <20131218.174801.1302082781180839324.davem@davemloft.net> (raw)
In-Reply-To: <1387190135-17052-5-git-send-email-peter@korsgaard.com>
From: Peter Korsgaard <peter@korsgaard.com>
Date: Mon, 16 Dec 2013 11:35:35 +0100
> Certain dm962x revisions contain an bug, where if a USB bulk transfer retry
> (E.G. if bulk crc mismatch) happens right after a transfer with odd or
> maxpacket length, the internal tx hardware fifo gets out of sync causing
> the interface to stop working.
>
> Work around it by adding up to 3 bytes of padding to ensure this situation
> cannot trigger.
>
> This workaround also means we never pass multiple-of-maxpacket size skb's
> to usbnet, so the length adjustment to handle usbnet's padding of those can
> be removed.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Joseph Chang <joseph_chang@davicom.com.tw>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Applied.
prev parent reply other threads:[~2013-12-18 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:35 [PATCH 0/4] dm9601: improve support for dm962x based devices Peter Korsgaard
2013-12-16 10:35 ` [PATCH 1/4] dm9601: add support for dm9621a based dongle Peter Korsgaard
2013-12-18 22:47 ` David Miller
2013-12-16 10:35 ` [PATCH 2/4] dm9601: fix reception of full size ethernet frames on dm9620/dm9621a Peter Korsgaard
2013-12-18 22:47 ` David Miller
2013-12-16 10:35 ` [PATCH 3/4] dm9601: make it clear that dm9620/dm9621a are also supported Peter Korsgaard
2013-12-18 22:47 ` David Miller
2013-12-16 10:35 ` [PATCH 4/4] dm9601: work around tx fifo sync issue on dm962x Peter Korsgaard
2013-12-18 22:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218.174801.1302082781180839324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joseph_chang@davicom.com.tw \
--cc=netdev@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).