Re: [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

On Tue, Dec 17, 2013 at 09:50:52PM +0000, Manish Chopra wrote:
> >-----Original Message-----
> >From: David Gibson [mailto:david@gibson.dropbear.id.au]
> >Sent: Tuesday, December 17, 2013 10:53 AM
> >To: Manish Chopra; Sony Chacko; Rajesh Borundia
> >Cc: netdev; snagarka@redhat.com; tcamuso@redhat.com;
> >vdasgupt@redhat.com
> >Subject: [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug
> >
> >At Red Hat, we've hit a couple of customer cases with crashes in the netxen driver
> >due to list corruption.  This seems to be very rarely triggered, and unfortunately
> >the dumps we have don't have enough information to be certain of the cause,
> >although we have a possible theory.
> >
> >I'm suggesting, therefore a patch to add some sanity checking which should help
> >to at least localize and mitigate the problem when someone hits it in future.
> >Please let me know if there's a better approach to doing this.
> >
> >That's 2/2.  1/2 is a fix for a clear bug I spotted along the way, but not one that
> >could cause the symptoms we've seen.
> 
> David,
> 
> Having these checks in data path(Rx path) may have some performance
> impact. It's better to root cause it instead of putting some sanity
> checks.

Obviously, but this was the best way I could think of to try narrowing
down the root cause (at least trying to eliminate driver vs. firmware
bug).

> We will get back to you on this.

If you have a better idea for locating the root cause, please let me
know.  I have access to a vmcore which I can poke around in.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]