From: David Miller <davem@davemloft.net>
To: yangyingliang@huawei.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH resend net-next] sch_tbf: add TBF_BURST/TBF_PBURST attribute
Date: Thu, 19 Dec 2013 15:03:14 -0500 (EST) [thread overview]
Message-ID: <20131219.150314.2040749867653163114.davem@davemloft.net> (raw)
In-Reply-To: <52AFC64F.2070100@huawei.com>
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 17 Dec 2013 11:34:39 +0800
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> When we set burst to 1514 with low rate in userspace,
> the kernel get a value of burst that less than 1514,
> which doesn't work.
>
> Because it may make some loss when transform burst
> to buffer in userspace. This makes burst lose some
> bytes, when the kernel transform the buffer back to
> burst.
>
> This patch adds two new attributes to support sending
> burst/mtu to kernel directly to avoid the loss.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
I really want to see some review of this change, thanks.
next prev parent reply other threads:[~2013-12-19 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 9:41 [PATCH net-next] sch_tbf: add TBF_BURST/TBF_PBURST attribute Yang Yingliang
2013-12-13 9:50 ` Duan Jiong
2013-12-16 2:11 ` Yang Yingliang
2013-12-17 3:34 ` [PATCH resend " Yang Yingliang
2013-12-19 20:03 ` David Miller [this message]
2013-12-19 20:15 ` Eric Dumazet
2013-12-20 1:24 ` [PATCH v3 " Yang Yingliang
2013-12-20 1:31 ` Eric Dumazet
2013-12-26 18:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219.150314.2040749867653163114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).