From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, Frank.Li@freescale.com, richardcochran@gmail.com
Subject: Re: [PATCH] net: fec: fix potential use after free
Date: Thu, 19 Dec 2013 18:31:05 -0500 (EST) [thread overview]
Message-ID: <20131219.183105.2179319099972646699.davem@davemloft.net> (raw)
In-Reply-To: <1387479182.19078.369.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 Dec 2013 10:53:02 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> skb_tx_timestamp(skb) should be called _before_ TX completion
> has a chance to trigger, otherwise it is too late and we access
> freed memory.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: de5fb0a05348 ("net: fec: put tx to napi poll function to fix dead lock")
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-12-19 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 18:53 [PATCH] net: fec: fix potential use after free Eric Dumazet
2013-12-19 19:32 ` Richard Cochran
2013-12-19 19:55 ` Frank.Li
2013-12-19 20:03 ` Eric Dumazet
2013-12-19 20:05 ` Eric Dumazet
2013-12-19 20:05 ` Frank Li
2013-12-19 20:18 ` Eric Dumazet
2013-12-19 20:30 ` Frank.Li
2013-12-19 23:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219.183105.2179319099972646699.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).