netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Arend van Spriel <arend@broadcom.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ben Hutchings <ben@decadent.org.uk>,
	Julian Calaby <julian.calaby@gmail.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ilw@linux.intel.com" <ilw@linux.intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	Avinash Patil <avinashapatil@gmail.com>
Subject: Re: [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work.
Date: Wed, 18 Dec 2013 20:57:26 -0800	[thread overview]
Message-ID: <20131219045726.GA3654@cerro.do-not-panic.com> (raw)
In-Reply-To: <4610721898.20131218204546@eikelenboom.it>

On Wed, Dec 18, 2013 at 08:45:46PM +0100, Sander Eikelenboom wrote:
> 
> Wednesday, December 18, 2013, 8:43:28 PM, you wrote:
> 
> > On Wed, Dec 18, 2013 at 11:48:45AM +0100, Sander Eikelenboom wrote:
> >> 
> >> Wednesday, December 18, 2013, 10:26:25 AM, you wrote:
> >> 
> >> > Hi all,
> >> 
> >> > We really should be asking Luis to look at this who hasn't yet chimed
> >> > in, presumably because he's between jobs (and travelling IIRC)
> >> 
> >> > On Wed, 2013-12-18 at 10:16 +0100, Arend van Spriel wrote:
> >> >> On 12/17/2013 11:06 PM, Linus Torvalds wrote:
> >> >> > We have literally had this *exact* same issue with firmware loading.
> >> >> > Network drivers shouldn't try to load firmware at module load time.
> >> >> > Same deal.
> >> >> 
> >> >> It is kind of a chicken and egg problem for (wireless) networking
> >> >> drivers. To get IFF_UP from the network layer you have to register a
> >> >> netdevice. For wireless drivers this means you have to register a wiphy
> >> >> device with cfg80211 which flags capabilities and optionally are custom
> >> >> regulatory domain. That information depends on the device and firmware
> >> >> used. And there we have a full circle.
> >> 
> >> > This is all really beside the point.
> >> 
> >> > For this CRDA information, the kernel never actually *waits* for it, so
> >> > in the case that there's no reply, it uses the built-in world domain. So
> >> > it's not like request_firmware(), which will block boot forever, but
> >> > it's also not like request_firmware_nowait() which will eventually time
> >> > out and come back with an error if userspace isn't handling it (though
> >> > now that firmware loading is built in ...)
> >> 
> >> > The issue is that it uses the built-in data *forever*, and what Sander
> >> > said was "or it will block forever" but just meant that it never was
> >> > able to do any further updates.
> >> 
> >> > It *doesn't* actually block the boot process or such. Everything Linus
> >> > said is true but seems to have been written in understanding "blocks" as
> >> > "blocking the boot process", rather than "blocking further updates".
> >> 
> >> > Regardless of this, even blocking further updates is a really bad idea.
> >> > There are a few ways to handle this, but I'll let Luis poke at that.
> >> 
> >> Your description is correct, sorry if I was not clear.
> 
> > We have a timeout handler for this, I'll check to see what's going on
> > by trying to reproduce on my end. Are you using wireless-testing ?
> 
> Originally 3.13-rc4, after that i tried with 3.13-rc4 with wireless-next pulled on top of it
> (since there were major changes to reg.c) but the problem occurs with both.

OK I can reproduce and am working on the cleanest solution. Thanks for
your report, I'll Cc ya when I have something reasonable baked up,
hopefully rather soon!

  Luis

  reply	other threads:[~2013-12-19  4:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18 17:43 [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work Sander Eikelenboom
     [not found] ` <1507831110.20131018194349-6SM94LqRVpn6gRhOQ7JHfg@public.gmane.org>
2013-10-23 12:28   ` Sander Eikelenboom
2013-12-11 15:17     ` Sander Eikelenboom
2013-12-11 15:38       ` Luis R. Rodriguez
2013-12-11 16:53         ` Sander Eikelenboom
2013-12-11 17:14           ` Luis R. Rodriguez
2013-12-11 17:28             ` Sander Eikelenboom
2013-12-11 17:53               ` Luis R. Rodriguez
2013-12-11 18:02                 ` Luis R. Rodriguez
2013-12-11 18:11                 ` Sander Eikelenboom
2013-12-11 18:38                   ` Luis R. Rodriguez
2013-12-11 19:06                     ` Sander Eikelenboom
2013-12-18 18:54                       ` Luis R. Rodriguez
2013-12-16 11:22                     ` Sander Eikelenboom
2013-12-16 11:37                       ` Arend van Spriel
2013-12-16 12:56                         ` Sander Eikelenboom
2013-12-17  2:17                           ` Julian Calaby
     [not found]                             ` <CAGRGNgXHemM2FfnXgW5RbzhFT+9SfUfVkjdysK3+=_u3hWSacw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-17  9:45                               ` Sander Eikelenboom
2013-12-17 20:33                                 ` Sander Eikelenboom
2013-12-17 21:27                                   ` Ben Hutchings
2013-12-17 21:49                                     ` Sander Eikelenboom
2013-12-17 22:06                                       ` Linus Torvalds
2013-12-18  9:16                                         ` Arend van Spriel
     [not found]                                           ` <52B167F6.5060209-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-12-18  9:18                                             ` Grumbach, Emmanuel
2013-12-18  9:25                                           ` Sander Eikelenboom
2013-12-18  9:26                                           ` Johannes Berg
2013-12-18 10:48                                             ` Sander Eikelenboom
2013-12-18 19:43                                               ` Luis R. Rodriguez
2013-12-18 19:45                                                 ` Sander Eikelenboom
2013-12-19  4:57                                                   ` Luis R. Rodriguez [this message]
2013-12-17 23:35                                       ` Julian Calaby
2013-12-18  7:50                                       ` Pontus Fuchs
2013-12-18  8:58                                         ` Arend van Spriel
2013-12-18 19:27                           ` Luis R. Rodriguez
2013-12-18 18:29                       ` Luis R. Rodriguez
2013-12-18 18:54                         ` Sander Eikelenboom
2013-12-18 19:42                           ` Luis R. Rodriguez
     [not found]         ` <CAJwzM1nwFa7z5gwh42aj39M2dxVXnuecDrhQkVyL+DDFAXwwbg@mail.gmail.com>
2013-12-11 17:00           ` Sander Eikelenboom
2013-12-11 17:17             ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219045726.GA3654@cerro.do-not-panic.com \
    --to=mcgrof@do-not-panic.com \
    --cc=arend@broadcom.com \
    --cc=avinashapatil@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=emmanuel.grumbach@intel.com \
    --cc=ilw@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).