From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Leigh Brown <leigh@solinno.co.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Nicolas Schichan <nschichan@freebox.fr>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Florian Fainelli <florian@openwrt.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] net: mvmdio: fix interrupt timeout handling
Date: Thu, 19 Dec 2013 10:43:34 -0700 [thread overview]
Message-ID: <20131219174334.GB10227@obsidianresearch.com> (raw)
In-Reply-To: <1387458588-17231-1-git-send-email-leigh@solinno.co.uk>
On Thu, Dec 19, 2013 at 01:09:48PM +0000, Leigh Brown wrote:
> This version corrects the whitespace issue.
>
> orion_mdio_wait_ready uses wait_event_timeout to wait for the
> SMI interrupt to fire. wait_event_timeout waits for between
> "timeout - 1" and "timeout" jiffies. In this case a 1ms timeout
> when HZ is 1000 results in a wait of 0 to 1 jiffies, causing
> premature timeouts.
>
> This fix ensures a minimum timeout of 2 jiffies, ensuring
> wait_event_timeout will always wait at least 1 jiffie.
>
> Issue reported by Nicolas Schichan.
>
> Tested-by: Nicolas Schichan <nschichan@freebox.fr>
> Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
> drivers/net/ethernet/marvell/mvmdio.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Leigh, I have just noticed a regression in 3.13-rc3 vs 3.10, on
kirkwood where 3.13 occasionally prints:
3 12/11 13:59:02 kernel: orion-mdio f1072004.mdio: Timeout: SMI busy for too long
Is that the same issue that this patch is addressing?
Regards,
Jason
next prev parent reply other threads:[~2013-12-19 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:13 [PATCH] net: mvmdio: fix interrupt timeout handling Leigh Brown
2013-12-19 11:33 ` Sebastian Hesselbarth
2013-12-19 12:39 ` Leigh Brown
2013-12-19 13:09 ` [PATCH v2] " Leigh Brown
2013-12-19 17:43 ` Jason Gunthorpe [this message]
2013-12-19 19:35 ` Leigh Brown
2013-12-20 0:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219174334.GB10227@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=jason@lakedaemon.net \
--cc=leigh@solinno.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nschichan@freebox.fr \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).