From: Richard Cochran <richardcochran@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
rashika.kheria@gmail.com, linux-kernel@vger.kernel.org,
dvhart@linux.intel.com, joe@perches.com,
andriy.shevchenko@linux.intel.com, vfalico@redhat.com,
netdev@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c
Date: Thu, 19 Dec 2013 20:23:52 +0100 [thread overview]
Message-ID: <20131219192352.GA14612@netboy> (raw)
In-Reply-To: <1387480400.1876.32.camel@bwh-desktop.uk.level5networks.com>
On Thu, Dec 19, 2013 at 07:13:20PM +0000, Ben Hutchings wrote:
>
> PTP is no longer a compile-time option in most net drivers.
Right, for those drivers where there is little or no performance
impact, there is no good reason not to enable the PTP bits.
But if the PTP code entails a run time cost, then we want it to be
optional, but not as a separate module. I suspect that the pch device
falls into this category, but I am not sure without taking another
look.
Thanks,
Richard
prev parent reply other threads:[~2013-12-19 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 20:44 [PATCH] drivers: ptp: Include new header file in ptp_pch.c Rashika Kheria
2013-12-15 21:01 ` Josh Triplett
2013-12-16 8:58 ` Richard Cochran
2013-12-18 22:43 ` David Miller
2013-12-18 23:40 ` josh
2013-12-19 7:27 ` Richard Cochran
2013-12-19 19:13 ` Ben Hutchings
2013-12-19 19:23 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219192352.GA14612@netboy \
--to=richardcochran@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).