From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiyou.wangcong@gmail.com, jhs@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net_sched: fix regression in tc_action_ops
Date: Fri, 20 Dec 2013 17:07:26 -0500 (EST) [thread overview]
Message-ID: <20131220.170726.1944817772969336273.davem@davemloft.net> (raw)
In-Reply-To: <1387571552.19078.468.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 Dec 2013 12:32:32 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> list_for_each_entry(a, &act_base, head) doesn't
> exit with a = NULL if we reached the end of the list.
>
> tcf_unregister_action(), tc_lookup_action_n() and tc_lookup_action()
> need fixes.
>
> Remove tc_lookup_action_id() as its unused and not worth 'fixing'
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Fixes: 1f747c26c48b ("net_sched: convert tc_action_ops to use struct list_head")
Applied.
next prev parent reply other threads:[~2013-12-20 22:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 8:08 [Patch net-next] net_sched: fix a regression in tc actions Cong Wang
2013-12-20 12:15 ` Jamal Hadi Salim
2013-12-20 14:37 ` Eric Dumazet
2013-12-20 14:46 ` Jamal Hadi Salim
2013-12-20 16:07 ` Eric Dumazet
2013-12-20 17:20 ` Eric Dumazet
2013-12-20 17:29 ` Eric Dumazet
2013-12-20 18:04 ` [PATCH net-next] net_sched: fix a regression in tcf_proto_lookup_ops() Eric Dumazet
2013-12-20 19:11 ` Cong Wang
2013-12-20 19:36 ` Eric Dumazet
2013-12-20 19:57 ` Cong Wang
2013-12-20 20:11 ` Eric Dumazet
2013-12-20 21:40 ` Cong Wang
2013-12-20 20:14 ` Eric Dumazet
2013-12-20 20:22 ` Jamal Hadi Salim
2013-12-20 21:30 ` David Miller
2013-12-20 20:32 ` [PATCH net-next] net_sched: fix regression in tc_action_ops Eric Dumazet
2013-12-20 21:35 ` Cong Wang
2013-12-20 22:07 ` David Miller [this message]
2013-12-20 22:07 ` [PATCH net-next] net_sched: fix a regression in tcf_proto_lookup_ops() David Miller
2013-12-20 18:49 ` [Patch net-next] net_sched: fix a regression in tc actions Cong Wang
2013-12-20 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220.170726.1944817772969336273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).