From: David Gibson <david@gibson.dropbear.id.au>
To: Manish Chopra <manish.chopra@qlogic.com>
Cc: Sony Chacko <sony.chacko@qlogic.com>,
Rajesh Borundia <rajesh.borundia@qlogic.com>,
netdev <netdev@vger.kernel.org>,
"snagarka@redhat.com" <snagarka@redhat.com>,
"tcamuso@redhat.com" <tcamuso@redhat.com>,
"vdasgupt@redhat.com" <vdasgupt@redhat.com>
Subject: Re: [PATCH 1/2] netxen: Correct off-by-one error in bounds check
Date: Fri, 20 Dec 2013 15:11:28 +1100 [thread overview]
Message-ID: <20131220041128.GB15958@voom.redhat.com> (raw)
In-Reply-To: <31AFFC7280259C4184970ABA9AFE8B938CF86A62@avmb3.qlogic.org>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
On Thu, Dec 19, 2013 at 11:51:37AM +0000, Manish Chopra wrote:
> >-----Original Message-----
> >From: David Gibson [mailto:david@gibson.dropbear.id.au]
> >Sent: Tuesday, December 17, 2013 10:53 AM
> >To: Manish Chopra; Sony Chacko; Rajesh Borundia
> >Cc: netdev; snagarka@redhat.com; tcamuso@redhat.com;
> >vdasgupt@redhat.com; David Gibson
> >Subject: [PATCH 1/2] netxen: Correct off-by-one error in bounds check
> >
> >After retrieving an Rx buffer index from the hardware, the netxen driver bounds
> >checks it against its array of receive buffers. However in the case of LRO packets,
> >there's an off-by-one error in the check - it uses > instead of the >= it uses for the
> >normal receive path in netxen_process_rcv().
> >
> >Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>
> Acked-by: Manish Chopra <manish.chopra@qlogic.com>
>
> Thanks David. This is really a bug fix. You can re-submit this single patch.
Ok, I added the extra fix Jiten suggested and resent.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-20 5:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 5:22 [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug David Gibson
2013-12-17 5:22 ` [PATCH 1/2] netxen: Correct off-by-one error in bounds check David Gibson
2013-12-17 6:37 ` Jitendra Kalsaria
2013-12-19 11:51 ` Manish Chopra
2013-12-20 4:11 ` David Gibson [this message]
2013-12-17 5:22 ` [PATCH 2/2] netxen: Add sanity checks for Rx buffers returning from hardware David Gibson
2013-12-19 20:05 ` David Miller
2014-01-24 5:21 ` David Gibson
2013-12-17 21:50 ` [0/2] netxen: bug fix and diagnostics for possible (hardware?) bug Manish Chopra
2013-12-18 6:22 ` David Gibson
2013-12-19 9:11 ` Manish Chopra
2014-01-24 6:44 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220041128.GB15958@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=snagarka@redhat.com \
--cc=sony.chacko@qlogic.com \
--cc=tcamuso@redhat.com \
--cc=vdasgupt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).