* [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices
@ 2013-12-20 12:21 Ezequiel Garcia
2013-12-20 12:35 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 12:21 UTC (permalink / raw)
To: netdev, linux-can; +Cc: Marc Kleine-Budde, Ezequiel Garcia
OMAP's ti_hecc driver is used to support the CAN controller on many
omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x).
Constrain the driver to OMAP2PLUS, which is the super-set of all the
other SoCs variants.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/net/can/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 3c06947..f0b106b 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -71,7 +71,7 @@ config CAN_AT91
and AT91SAM9X5 processors.
config CAN_TI_HECC
- depends on ARCH_OMAP3
+ depends on ARCH_OMAP2PLUS
tristate "TI High End CAN Controller"
---help---
Driver for TI HECC (High End CAN Controller) module found on many
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices
2013-12-20 12:21 [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices Ezequiel Garcia
@ 2013-12-20 12:35 ` Marc Kleine-Budde
2013-12-20 12:52 ` Ezequiel Garcia
0 siblings, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2013-12-20 12:35 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: netdev, linux-can
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On 12/20/2013 01:21 PM, Ezequiel Garcia wrote:
> OMAP's ti_hecc driver is used to support the CAN controller on many
> omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x).
> Constrain the driver to OMAP2PLUS, which is the super-set of all the
> other SoCs variants.
Why not enable it for all ARM platforms to get a bigger compile coverage?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices
2013-12-20 12:35 ` Marc Kleine-Budde
@ 2013-12-20 12:52 ` Ezequiel Garcia
2013-12-20 19:56 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 12:52 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: netdev, linux-can
On Fri, Dec 20, 2013 at 01:35:58PM +0100, Marc Kleine-Budde wrote:
> On 12/20/2013 01:21 PM, Ezequiel Garcia wrote:
> > OMAP's ti_hecc driver is used to support the CAN controller on many
> > omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x).
> > Constrain the driver to OMAP2PLUS, which is the super-set of all the
> > other SoCs variants.
>
> Why not enable it for all ARM platforms to get a bigger compile coverage?
>
Hm.. Isn't the COMPILE_TEST option for getting compile coverage?
If the IP is only available on OMAP SoCs, it makes sense to only allow
building it there, but I don't really have a strong opinion.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices
2013-12-20 12:52 ` Ezequiel Garcia
@ 2013-12-20 19:56 ` Marc Kleine-Budde
0 siblings, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2013-12-20 19:56 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: netdev, linux-can
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On 12/20/2013 01:52 PM, Ezequiel Garcia wrote:
> On Fri, Dec 20, 2013 at 01:35:58PM +0100, Marc Kleine-Budde wrote:
>> On 12/20/2013 01:21 PM, Ezequiel Garcia wrote:
>>> OMAP's ti_hecc driver is used to support the CAN controller on many
>>> omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x).
>>> Constrain the driver to OMAP2PLUS, which is the super-set of all the
>>> other SoCs variants.
>>
>> Why not enable it for all ARM platforms to get a bigger compile coverage?
>>
>
> Hm.. Isn't the COMPILE_TEST option for getting compile coverage?
>
> If the IP is only available on OMAP SoCs, it makes sense to only allow
> building it there, but I don't really have a strong opinion.
We've replaced the depends on ARCH_* in the flexcan and at91 driver by a
depends on ARM.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-20 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 12:21 [PATCH] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices Ezequiel Garcia
2013-12-20 12:35 ` Marc Kleine-Budde
2013-12-20 12:52 ` Ezequiel Garcia
2013-12-20 19:56 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).